Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 2641633002: Only set certificate on DTLS transport if fingerprint is found in SDP. (Closed)

Created:
3 years, 11 months ago by Taylor Brandstetter
Modified:
3 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only set certificate on DTLS transport if fingerprint is found in SDP. This is used for fallback from DTLS to SDES encryption, which we probably still want to support. Setting a certificate puts the DTLS transport in a "DTLS enabled" mode, so it should be delayed until SDP with "a=fingerprint" is set. BUG=webrtc:6972 Review-Url: https://codereview.webrtc.org/2641633002 Cr-Commit-Position: refs/heads/master@{#16199} Committed: https://chromium.googlesource.com/external/webrtc/+/8662f940230bb0f8989ddc993488cde3a9c5b76a

Patch Set 1 #

Patch Set 2 : Merge with master #

Patch Set 3 : Fix tests by making FakeTransportController::Connect put fingerprints in transport descriptions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -16 lines) Patch
M webrtc/api/peerconnectioninterface_unittest.cc View 4 chunks +48 lines, -1 line 0 comments Download
M webrtc/api/test/fakertccertificategenerator.h View 3 chunks +4 lines, -0 lines 0 comments Download
M webrtc/base/sslfingerprint.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M webrtc/base/sslfingerprint.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M webrtc/p2p/base/jseptransport.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 1 2 chunks +4 lines, -11 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
pthatcher1
lgtm
3 years, 11 months ago (2017-01-20 19:31:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2641633002/20001
3 years, 11 months ago (2017-01-21 02:38:59 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/22253) linux_ubsan on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 11 months ago (2017-01-21 02:46:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2641633002/40001
3 years, 11 months ago (2017-01-21 04:12:52 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 05:20:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/8662f940230bb0f8989ddc993...

Powered by Google App Engine
This is Rietveld 408576698