webrtc/p2p/base/jseptransport.cc - Issue 2641633002: Only set certificate on DTLS transport if fingerprint is found in SDP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/jseptransport.cc

Issue 2641633002: Only set certificate on DTLS transport if fingerprint is found in SDP. (Closed)

Patch Set: Fix tests by making FakeTransportController::Connect put fingerprints in transport descriptions. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/p2p/base/jseptransport.cc

diff --git a/webrtc/p2p/base/jseptransport.cc b/webrtc/p2p/base/jseptransport.cc

index 159c238a7937128f9dc4ce0172019061ab39c2ad..9018a643d87a7c45ccf0422fca4d1da3d6775c55 100644

--- a/webrtc/p2p/base/jseptransport.cc

+++ b/webrtc/p2p/base/jseptransport.cc

@@ -329,7 +329,12 @@ bool JsepTransport::ApplyLocalTransportDescription(

std::string* error_desc) {

dtls_transport->ice_transport()->SetIceParameters(

local_description_->GetIceParameters());

- return true;

+ bool ret = true;

+ if (certificate_) {

+ ret = dtls_transport->SetLocalCertificate(certificate_);

+ RTC_DCHECK(ret);

+ }

+ return ret;

}

bool JsepTransport::ApplyRemoteTransportDescription(

« no previous file with comments | « webrtc/p2p/base/faketransportcontroller.h ('k') | webrtc/p2p/base/transportcontroller.cc » ('j') | no next file with comments »