Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2640743007: Fix msan flake in rtcstats_integrationtest.cc. (Closed)

Created:
3 years, 11 months ago by hbos
Modified:
3 years, 11 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix msan flake in rtcstats_integrationtest.cc. This CL https://codereview.webrtc.org/2641763003 changed echo return loss /...enhancement stats from being optional to being undefined because that was the observed behavior (and a TODO was added to investigate why). It turns out that these stats are sometimes available, e.g. if the test runs for a while like MSAN bot does, so this turned the test flaky. Example failure: https://build.chromium.org/p/client.webrtc/builders/Linux%20MSan/builds/8242 This CL reverts that change without reverting the rest of the CL which other CLs depend on, and updates the TODO. BUG=chromium:627816 TBR=hta@webrtc.org NOTRY=True NOPRESUBMIT=True Review-Url: https://codereview.webrtc.org/2640743007 Cr-Commit-Position: refs/heads/master@{#16187} Committed: https://chromium.googlesource.com/external/webrtc/+/2d4d653e1fd25ade9ae768058b1225e6b430bc76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M webrtc/api/rtcstats_integrationtest.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2640743007/20001
3 years, 11 months ago (2017-01-20 12:16:37 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 12:16:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/2d4d653e1fd25ade9ae768058...

Powered by Google App Engine
This is Rietveld 408576698