Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: webrtc/api/rtcstats_integrationtest.cc

Issue 2640743007: Fix msan flake in rtcstats_integrationtest.cc. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstats_integrationtest.cc
diff --git a/webrtc/api/rtcstats_integrationtest.cc b/webrtc/api/rtcstats_integrationtest.cc
index 5ded4470ea5fb13d019e4f7a91e869f435bc08a8..f89207a0dc5c066cc5dbe090f6cc23ceefd28ac1 100644
--- a/webrtc/api/rtcstats_integrationtest.cc
+++ b/webrtc/api/rtcstats_integrationtest.cc
@@ -471,13 +471,13 @@ class RTCStatsReportVerifier {
verifier.TestMemberIsUndefined(media_stream_track.full_frames_lost);
// Audio-only members
verifier.TestMemberIsNonNegative<double>(media_stream_track.audio_level);
- // TODO(hbos): Find out why |echo_return_loss| and
- // |echo_return_loss_enhancement| are undefined in the integration test.
- // Is this a real problem or a test problem? Update test so that they are.
- // crbug.com/627816
- verifier.TestMemberIsUndefined(media_stream_track.echo_return_loss);
- verifier.TestMemberIsUndefined(
- media_stream_track.echo_return_loss_enhancement);
+ // TODO(hbos): |echo_return_loss| and |echo_return_loss_enhancement| are
+ // flaky on msan bot (sometimes defined, sometimes undefined). Should the
+ // test run until available or is there a way to have it always be
+ // defined? crbug.com/627816
+ verifier.MarkMemberTested(media_stream_track.echo_return_loss, true);
+ verifier.MarkMemberTested(
+ media_stream_track.echo_return_loss_enhancement, true);
}
return verifier.ExpectAllMembersSuccessfullyTested();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698