Fix PseudoTcp to handle incoming packets with invalid SEQ field

Fix PseudoTcp to handle incoming packets with invalid SEQ field

Previously PseudoTcp::process() didn't handle the case when the peer
sends a packet that's outside of the receive window, which was causing
DCHECK failures in the fuzzer.

BUG=681849
Review-Url: https://codereview.webrtc.org/2640173002
Cr-Commit-Position: refs/heads/master@{#16169}
Committed: https://chromium.googlesource.com/external/webrtc/+/d74886350e432547e7a70095170fe1a9a0dab0c8

[Sergey Ulanov, 2017-01-18 22:06:31]

sergeyu@chromium.org changed reviewers:
+ nisse@webrtc.org

[nisse-webrtc, 2017-01-19 07:44:16]

lgtm

Would it make sense to write a unit test for invalid input? Depends on
difficulty of testing, and expected life time of this code, I guess.

https://codereview.webrtc.org/2640173002/diff/1/webrtc/p2p/base/pseudotcp.cc
File webrtc/p2p/base/pseudotcp.cc (right):

https://codereview.webrtc.org/2640173002/diff/1/webrtc/p2p/base/pseudotcp.cc#...
webrtc/p2p/base/pseudotcp.cc:921: RTC_UNUSED(result);
You can delete this RTC_UNUSED, it's a left over from my conversion from ASSERT
to RTC_CHECK.

[Sergey Ulanov, 2017-01-19 18:06:33]

> Would it make sense to write a unit test for invalid input? Depends on
> difficulty of testing, and expected life time of this code, I guess.

There are currently no unittests for this class, and I don't think it's worth
adding them because we won't need this code in the future. Hopefully we will be
able to remove it this year.

https://codereview.webrtc.org/2640173002/diff/1/webrtc/p2p/base/pseudotcp.cc
File webrtc/p2p/base/pseudotcp.cc (right):

https://codereview.webrtc.org/2640173002/diff/1/webrtc/p2p/base/pseudotcp.cc#...
webrtc/p2p/base/pseudotcp.cc:921: RTC_UNUSED(result);
On 2017/01/19 07:44:16, nisse-webrtc wrote:
> You can delete this RTC_UNUSED, it's a left over from my conversion from
ASSERT
> to RTC_CHECK.
> 

Done.

[Sergey Ulanov, 2017-01-19 18:06:37]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2017-01-19 18:06:37]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2640173002/#ps20001 (title:
".")

[commit-bot: I haz the power, 2017-01-19 18:06:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-19 18:53:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484849197339380,
"parent_rev": "3cd896c9620de87e173d83021bae1b70803a3f1a", "commit_rev":
"d74886350e432547e7a70095170fe1a9a0dab0c8"}

[commit-bot: I haz the power, 2017-01-19 18:53:38]

Description was changed from

==========
Fix PseudoTcp to handle incoming packets with invalid SEQ field

Previously PseudoTcp::process() didn't handle the case when the peer
sends a packet that's outside of the receive window, which was causing
DCHECK failures in the fuzzer.

BUG=681849
==========

to

==========
Fix PseudoTcp to handle incoming packets with invalid SEQ field

Previously PseudoTcp::process() didn't handle the case when the peer
sends a packet that's outside of the receive window, which was causing
DCHECK failures in the fuzzer.

BUG=681849

Review-Url: https://codereview.webrtc.org/2640173002
Cr-Commit-Position: refs/heads/master@{#16169}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d74886350e432547e7a700951...
==========

[commit-bot: I haz the power, 2017-01-19 18:53:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/d74886350e432547e7a700951...