Fix PseudoTcp to handle incoming packets with invalid SEQ field

webrtc/p2p/base/pseudotcp.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 892 matching lines @@
   bool bNewData = false;
 
   if (seg.len > 0) {
     if (bIgnoreData) {
       if (seg.seq == m_rcv_nxt) {
         m_rcv_nxt += seg.len;
       }
     } else {
       uint32_t nOffset = seg.seq - m_rcv_nxt;
 
-      rtc::StreamResult result = m_rbuf.WriteOffset(seg.data, seg.len,
-                                                          nOffset, NULL);
+      rtc::StreamResult result =
+          m_rbuf.WriteOffset(seg.data, seg.len, nOffset, NULL);
+      if (result == rtc::SR_BLOCK) {
+        // Ignore incoming packets outside of the receive window.
+        return false;
+      }
+
       RTC_DCHECK(result == rtc::SR_SUCCESS);
       RTC_UNUSED(result);

[nisse-webrtc, 2017/01/19 07:44:16]

You can delete this RTC_UNUSED, it's a left over from my conversion from ASSERT
to RTC_CHECK.

[Sergey Ulanov, 2017/01/19 18:06:32]

Done.

 
       if (seg.seq == m_rcv_nxt) {
         m_rbuf.ConsumeWriteBuffer(seg.len);
         m_rcv_nxt += seg.len;
         m_rcv_wnd -= seg.len;
         bNewData = true;
 
         RList::iterator it = m_rlist.begin();
         while ((it != m_rlist.end()) && (it->seq <= m_rcv_nxt)) {
           if (it->seq + it->len > m_rcv_nxt) {
@@ skipping 351 matching lines @@
   m_rbuf_len = new_size;
   m_rwnd_scale = scale_factor;
   m_ssthresh = new_size;
 
   size_t available_space = 0;
   m_rbuf.GetWriteRemaining(&available_space);
   m_rcv_wnd = static_cast<uint32_t>(available_space);
 }
 
 }  // namespace cricket