Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2639573002: Revert of Fix flaky WebRtcVideoChannel2BaseTest.GetStats T (Closed)

Created:
3 years, 11 months ago by perkj_webrtc
Modified:
3 years, 11 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Fix flaky WebRtcVideoChannel2BaseTest.GetStats T (patchset #1 id:1 of https://codereview.webrtc.org/2634273002/ ) Reason for revert: nisse landed a change that always disable adaptation in these tests. Original issue's description: > Fix flaky WebRtcVideoChannel2BaseTest.GetStats T > This cl allows width and height of the produced encoded stream to be smaller than the configured camera resolution. This is since quality and cpu adapters may request a scaled input frame. > > BUG=webrtc:6990 > > Review-Url: https://codereview.webrtc.org/2634273002 > Cr-Commit-Position: refs/heads/master@{#16118} > Committed: https://chromium.googlesource.com/external/webrtc/+/311a64ccf535d5013c5cd2c46795a37260d06165 TBR=sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6990 Review-Url: https://codereview.webrtc.org/2639573002 Cr-Commit-Position: refs/heads/master@{#16120} Committed: https://chromium.googlesource.com/external/webrtc/+/0b2d3e217f8d63f69d2014c8f708a76bfaac2d59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M webrtc/media/base/videoengine_unittest.h View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
perkj_webrtc
Created Revert of Fix flaky WebRtcVideoChannel2BaseTest.GetStats T
3 years, 11 months ago (2017-01-17 13:56:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2639573002/1
3 years, 11 months ago (2017-01-17 13:56:48 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 13:56:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/0b2d3e217f8d63f69d2014c8f...

Powered by Google App Engine
This is Rietveld 408576698