Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2634273002: Fix flaky WebRtcVideoChannel2BaseTest.GetStats T (Closed)

Created:
3 years, 11 months ago by perkj_webrtc
Modified:
3 years, 11 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix flaky WebRtcVideoChannel2BaseTest.GetStats T This cl allows width and height of the produced encoded stream to be smaller than the configured camera resolution. This is since quality and cpu adapters may request a scaled input frame. BUG=webrtc:6990 Review-Url: https://codereview.webrtc.org/2634273002 Cr-Commit-Position: refs/heads/master@{#16118} Committed: https://chromium.googlesource.com/external/webrtc/+/311a64ccf535d5013c5cd2c46795a37260d06165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M webrtc/media/base/videoengine_unittest.h View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
perkj_webrtc
please?
3 years, 11 months ago (2017-01-17 10:33:06 UTC) #4
sprang_webrtc
lgtm
3 years, 11 months ago (2017-01-17 12:31:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2634273002/1
3 years, 11 months ago (2017-01-17 12:34:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/311a64ccf535d5013c5cd2c46795a37260d06165
3 years, 11 months ago (2017-01-17 12:37:06 UTC) #12
perkj_webrtc
3 years, 11 months ago (2017-01-17 13:56:40 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2639573002/ by perkj@webrtc.org.

The reason for reverting is: nisse landed  a change that always disable
adaptation in these tests..

Powered by Google App Engine
This is Rietveld 408576698