Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2628563002:
Remove some Android lint suppressions. (Closed)
DescriptionRemove some Android lint suppressions.
These were the easiest to remove, so let's start with these.
BUG=webrtc:6597
R=magjed@webrtc.org
TBR=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/2628563002
Cr-Commit-Position: refs/heads/master@{#16023}
Committed: https://chromium.googlesource.com/external/webrtc/+/77dc71f0f5bbba1904f115794ef1f6ec298e8c63
Patch Set 1 #Patch Set 2 : Rebase. #
Messages
Total messages: 30 (20 generated)
Description was changed from ========== Remove some Android lint suppressions. BUG=webrtc:6597 R=magjed@webrtc.org ========== to ========== Remove some Android lint suppressions. These were the easiest to remove, so let's start with these. BUG=webrtc:6597 R=magjed@webrtc.org ==========
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
PTAL
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12070)
sakal@webrtc.org changed reviewers: + kjellander@webrtc.org
kjellander, PTAL.
Description was changed from ========== Remove some Android lint suppressions. These were the easiest to remove, so let's start with these. BUG=webrtc:6597 R=magjed@webrtc.org ========== to ========== Remove some Android lint suppressions. These were the easiest to remove, so let's start with these. BUG=webrtc:6597 R=magjed@webrtc.org TBR=kjellander@webrtc.org ==========
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...) ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/16205) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/21598)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by sakal@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sakal@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org Link to the patchset: https://codereview.webrtc.org/2628563002/#ps40001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484208876677770,
"parent_rev": "54a8ca5aa080b80b5016948542da958f864fbab0", "commit_rev":
"77dc71f0f5bbba1904f115794ef1f6ec298e8c63"}
Message was sent while issue was closed.
Description was changed from ========== Remove some Android lint suppressions. These were the easiest to remove, so let's start with these. BUG=webrtc:6597 R=magjed@webrtc.org TBR=kjellander@webrtc.org ========== to ========== Remove some Android lint suppressions. These were the easiest to remove, so let's start with these. BUG=webrtc:6597 R=magjed@webrtc.org TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2628563002 Cr-Commit-Position: refs/heads/master@{#16023} Committed: https://chromium.googlesource.com/external/webrtc/+/77dc71f0f5bbba1904f115794... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/77dc71f0f5bbba1904f115794...
Message was sent while issue was closed.
Thank you! lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
