webrtc/examples/androidtests/src/org/appspot/apprtc/test/FileVideoCapturerTest.java - Issue 2628563002: Remove some Android lint suppressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/androidtests/src/org/appspot/apprtc/test/FileVideoCapturerTest.java

Issue 2628563002: Remove some Android lint suppressions. (Closed)

Patch Set: Rebase. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/build/android/suppressions.xml ('k') | webrtc/examples/androidtests/src/org/appspot/apprtc/test/VideoFileRendererTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/examples/androidtests/src/org/appspot/apprtc/test/FileVideoCapturerTest.java

diff --git a/webrtc/examples/androidtests/src/org/appspot/apprtc/test/FileVideoCapturerTest.java b/webrtc/examples/androidtests/src/org/appspot/apprtc/test/FileVideoCapturerTest.java

index 1a61d58c1d2f48de16c7543b1c17788e66ace0c3..cf2924b7a3d08753f96241b5b63126d9ced67a75 100644

--- a/webrtc/examples/androidtests/src/org/appspot/apprtc/test/FileVideoCapturerTest.java

+++ b/webrtc/examples/androidtests/src/org/appspot/apprtc/test/FileVideoCapturerTest.java

@@ -13,6 +13,7 @@ package org.appspot.apprtc.test;

import static org.junit.Assert.assertEquals;

import static org.junit.Assert.assertTrue;

+import android.os.Environment;

import android.support.test.filters.LargeTest;

import android.support.test.filters.MediumTest;

import android.support.test.filters.SmallTest;

@@ -80,9 +81,10 @@ public class FileVideoCapturerTest {

public void testVideoCaptureFromFile() throws InterruptedException, IOException {

final int FRAME_WIDTH = 4;

final int FRAME_HEIGHT = 4;

- final FileVideoCapturer fileVideoCapturer = new FileVideoCapturer(

- "/sdcard/chromium_tests_root/webrtc/examples/androidtests/src/org/appspot/apprtc/test/"

- + "capturetestvideo.y4m");

+ final FileVideoCapturer fileVideoCapturer =

+ new FileVideoCapturer(Environment.getExternalStorageDirectory().getPath()

+ + "/chromium_tests_root/webrtc/examples/androidtests/src/org/appspot/apprtc/test/"

+ + "capturetestvideo.y4m");

final MockCapturerObserver capturerObserver = new MockCapturerObserver();

fileVideoCapturer.initialize(null, null, capturerObserver);

fileVideoCapturer.startCapture(FRAME_WIDTH, FRAME_HEIGHT, 33);