Move MetricsObserverInterface out of peerconnectioninterface.h

Move MetricsObserverInterface out of peerconnectioninterface.h

This change moves the definition of the UMA MetricsObserverInterface from api/peerconnectioninterface.h into api/umametrics.h. This allows us to remove the unwanted dependency on peerconnectioninterface.h from files in webrtc/p2p.

This is a simple refactoring with no functional changes.

BUG=None

Review-Url: https://codereview.webrtc.org/2627093005
Cr-Commit-Position: refs/heads/master@{#16020}
Committed: https://chromium.googlesource.com/external/webrtc/+/1d3c7e0b16fb5af637be34b29a4ac19e20ce3cab

[skvlad, 2017-01-11 23:39:06]

The CQ bit was checked by skvlad@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 23:39:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[skvlad, 2017-01-11 23:41:01]

skvlad@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[commit-bot: I haz the power, 2017-01-12 00:21:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 00:21:55]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-01-12 00:34:53]

lgtm

[skvlad, 2017-01-12 00:46:02]

The CQ bit was checked by skvlad@webrtc.org

[commit-bot: I haz the power, 2017-01-12 00:46:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-12 00:48:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 00:48:44]

Failed to apply patch for webrtc/api/peerconnectioninterface.h:
While running git apply --index -p1;
  error: patch failed: webrtc/api/peerconnectioninterface.h:122
  error: webrtc/api/peerconnectioninterface.h: patch does not apply

Patch:       webrtc/api/peerconnectioninterface.h
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h
b/webrtc/api/peerconnectioninterface.h
index
5f5a58b4319295312cf169a612855b897d73a9af..e484a89af19eaccc94858ef1b26a33a9b07fb76d
100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -122,33 +122,6 @@ class StatsObserver : public rtc::RefCountInterface {
   virtual ~StatsObserver() {}
 };
 
-class MetricsObserverInterface : public rtc::RefCountInterface {
- public:
-
-  // |type| is the type of the enum counter to be incremented. |counter|
-  // is the particular counter in that type. |counter_max| is the next sequence
-  // number after the highest counter.
-  virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type,
-                                    int counter,
-                                    int counter_max) {}
-
-  // This is used to handle sparse counters like SSL cipher suites.
-  // TODO(guoweis): Remove the implementation once the dependency's interface
-  // definition is updated.
-  virtual void IncrementSparseEnumCounter(PeerConnectionEnumCounterType type,
-                                          int counter) {
-    IncrementEnumCounter(type, counter, 0 /* Ignored */);
-  }
-
-  virtual void AddHistogramSample(PeerConnectionMetricsName type,
-                                  int value) = 0;
-
- protected:
-  virtual ~MetricsObserverInterface() {}
-};
-
-typedef MetricsObserverInterface UMAObserver;
-
 // Enumeration to represent distinct classes of errors that an application
 // may wish to act upon differently. These roughly map to DOMExceptions in
 // the web API, as described in the comments below.

[skvlad, 2017-01-12 00:52:34]

The CQ bit was checked by skvlad@webrtc.org

[skvlad, 2017-01-12 00:52:34]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2627093005/#ps20001 (title:
"Rebase")

[commit-bot: I haz the power, 2017-01-12 00:52:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-12 01:50:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484182354284910,
"parent_rev": "fce6f825b4a767534ca69141b3ca716a8e5c29ef", "commit_rev":
"1d3c7e0b16fb5af637be34b29a4ac19e20ce3cab"}

[commit-bot: I haz the power, 2017-01-12 01:50:35]

Description was changed from

==========
Move MetricsObserverInterface out of peerconnectioninterface.h

This change moves the definition of the UMA MetricsObserverInterface from
api/peerconnectioninterface.h into api/umametrics.h. This allows us to remove
the unwanted dependency on peerconnectioninterface.h from files in webrtc/p2p.

This is a simple refactoring with no functional changes.

BUG=None
==========

to

==========
Move MetricsObserverInterface out of peerconnectioninterface.h

This change moves the definition of the UMA MetricsObserverInterface from
api/peerconnectioninterface.h into api/umametrics.h. This allows us to remove
the unwanted dependency on peerconnectioninterface.h from files in webrtc/p2p.

This is a simple refactoring with no functional changes.

BUG=None

Review-Url: https://codereview.webrtc.org/2627093005
Cr-Commit-Position: refs/heads/master@{#16020}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1d3c7e0b16fb5af637be34b29...
==========

[commit-bot: I haz the power, 2017-01-12 01:50:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/1d3c7e0b16fb5af637be34b29...