Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2627093005: Move MetricsObserverInterface out of peerconnectioninterface.h (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/umametrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index 5e1fd327e221bcc9b1493f7b16e6e52e6ac3337b..4e0739b26bf033960570c22012b34089bb30f74f 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -122,33 +122,6 @@ class StatsObserver : public rtc::RefCountInterface {
virtual ~StatsObserver() {}
};
-class MetricsObserverInterface : public rtc::RefCountInterface {
- public:
-
- // |type| is the type of the enum counter to be incremented. |counter|
- // is the particular counter in that type. |counter_max| is the next sequence
- // number after the highest counter.
- virtual void IncrementEnumCounter(PeerConnectionEnumCounterType type,
- int counter,
- int counter_max) {}
-
- // This is used to handle sparse counters like SSL cipher suites.
- // TODO(guoweis): Remove the implementation once the dependency's interface
- // definition is updated.
- virtual void IncrementSparseEnumCounter(PeerConnectionEnumCounterType type,
- int counter) {
- IncrementEnumCounter(type, counter, 0 /* Ignored */);
- }
-
- virtual void AddHistogramSample(PeerConnectionMetricsName type,
- int value) = 0;
-
- protected:
- virtual ~MetricsObserverInterface() {}
-};
-
-typedef MetricsObserverInterface UMAObserver;
-
// Enumeration to represent distinct classes of errors that an application
// may wish to act upon differently. These roughly map to DOMExceptions or
// RTCError "errorDetailEnum" values in the web API, as described in the
« no previous file with comments | « no previous file | webrtc/api/umametrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698