Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issue 2625993002: RTCTransportStats.dtlsState replaces .activeConnection (Closed)

Created:
3 years, 11 months ago by hbos
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCTransportStats.dtlsState replaces .activeConnection In accordance with recent spec change: https://github.com/w3c/webrtc-stats/pull/122 BUG=chromium:653873, chromium:627816 Review-Url: https://codereview.webrtc.org/2625993002 Cr-Commit-Position: refs/heads/master@{#16098} Committed: https://chromium.googlesource.com/external/webrtc/+/7064d5929a978aad8c3ce6cab61cef2c8c9203be

Patch Set 1 #

Patch Set 2 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M webrtc/api/rtcstats_integrationtest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/rtcstatscollector.cc View 2 chunks +21 lines, -2 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 1 6 chunks +5 lines, -4 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 2 chunks +11 lines, -1 line 0 comments Download
M webrtc/p2p/base/jseptransport.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/jseptransport.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 1 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
hbos
Please take a look hta, deadbeef.
3 years, 11 months ago (2017-01-11 12:43:04 UTC) #5
Taylor Brandstetter
lgtm
3 years, 11 months ago (2017-01-11 19:43:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2625993002/40001
3 years, 11 months ago (2017-01-16 13:08:39 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 15:38:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/7064d5929a978aad8c3ce6cab...

Powered by Google App Engine
This is Rietveld 408576698