Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: webrtc/api/rtcstatscollector_unittest.cc

Issue 2625993002: RTCTransportStats.dtlsState replaces .activeConnection (Closed)
Patch Set: Rebase with master Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | webrtc/api/stats/rtcstats_objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstatscollector_unittest.cc
diff --git a/webrtc/api/rtcstatscollector_unittest.cc b/webrtc/api/rtcstatscollector_unittest.cc
index a9426622fb391cddbe54edf32b9ef4a9724a235e..bac93f3104498b40e79424dc46acffdd727f909b 100644
--- a/webrtc/api/rtcstatscollector_unittest.cc
+++ b/webrtc/api/rtcstatscollector_unittest.cc
@@ -1866,6 +1866,7 @@ TEST_F(RTCStatsCollectorTest, CollectRTCTransportStats) {
cricket::TransportChannelStats rtp_transport_channel_stats;
rtp_transport_channel_stats.component = cricket::ICE_CANDIDATE_COMPONENT_RTP;
rtp_transport_channel_stats.connection_infos.push_back(rtp_connection_info);
+ rtp_transport_channel_stats.dtls_state = cricket::DTLS_TRANSPORT_NEW;
session_stats.transport_stats["transport"].channel_stats.push_back(
rtp_transport_channel_stats);
@@ -1885,7 +1886,7 @@ TEST_F(RTCStatsCollectorTest, CollectRTCTransportStats) {
report->timestamp_us());
expected_rtp_transport.bytes_sent = 42;
expected_rtp_transport.bytes_received = 1337;
- expected_rtp_transport.active_connection = false;
+ expected_rtp_transport.dtls_state = RTCDtlsTransportState::kNew;
ASSERT_TRUE(report->Get(expected_rtp_transport.id()));
EXPECT_EQ(
@@ -1902,6 +1903,7 @@ TEST_F(RTCStatsCollectorTest, CollectRTCTransportStats) {
rtcp_transport_channel_stats.component =
cricket::ICE_CANDIDATE_COMPONENT_RTCP;
rtcp_transport_channel_stats.connection_infos.push_back(rtcp_connection_info);
+ rtcp_transport_channel_stats.dtls_state = cricket::DTLS_TRANSPORT_CONNECTING;
session_stats.transport_stats["transport"].channel_stats.push_back(
rtcp_transport_channel_stats);
@@ -1915,7 +1917,7 @@ TEST_F(RTCStatsCollectorTest, CollectRTCTransportStats) {
report->timestamp_us());
expected_rtcp_transport.bytes_sent = 1337;
expected_rtcp_transport.bytes_received = 42;
- expected_rtcp_transport.active_connection = false;
+ expected_rtcp_transport.dtls_state = RTCDtlsTransportState::kConnecting;
expected_rtp_transport.rtcp_transport_stats_id = expected_rtcp_transport.id();
@@ -1928,7 +1930,7 @@ TEST_F(RTCStatsCollectorTest, CollectRTCTransportStats) {
expected_rtcp_transport,
report->Get(expected_rtcp_transport.id())->cast_to<RTCTransportStats>());
- // Get stats with an active connection.
+ // Get stats with an active connection (selected candidate pair).
session_stats.transport_stats["transport"]
.channel_stats[1]
.connection_infos[0]
@@ -1937,7 +1939,6 @@ TEST_F(RTCStatsCollectorTest, CollectRTCTransportStats) {
collector_->ClearCachedStatsReport();
report = GetStatsReport();
- expected_rtcp_transport.active_connection = true;
expected_rtcp_transport.selected_candidate_pair_id =
"RTCIceCandidatePair_" + rtcp_local_candidate->id() + "_" +
rtcp_remote_candidate->id();
« no previous file with comments | « webrtc/api/rtcstatscollector.cc ('k') | webrtc/api/stats/rtcstats_objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698