Signal target bitrate only for screenshare streams

Signal target bitrate only for screenshare streams

BUG=webrtc:6301
Review-Url: https://codereview.webrtc.org/2625893004
Cr-Commit-Position: refs/heads/master@{#16058}
Committed: https://chromium.googlesource.com/external/webrtc/+/44b3ef65ed562aec042c0f1d29a983207228e40e

[sprang_webrtc, 2017-01-12 10:31:06]

sprang@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[danilchap, 2017-01-12 11:27:57]

lgtm

https://codereview.webrtc.org/2625893004/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2625893004/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:621: // Only signal target bitrate for
screenshare streams, for now.
Can you write a TODO when it should be turned on for non-screenshare too?
(instead of 'for now')

[sprang_webrtc, 2017-01-12 11:52:14]

https://codereview.webrtc.org/2625893004/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2625893004/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:621: // Only signal target bitrate for
screenshare streams, for now.
On 2017/01/12 11:27:57, danilchap wrote:
> Can you write a TODO when it should be turned on for non-screenshare too?
> (instead of 'for now')

Done.

[sprang_webrtc, 2017-01-12 11:52:17]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2017-01-12 11:52:18]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2625893004/#ps20001 (title:
"comment")

[commit-bot: I haz the power, 2017-01-12 11:52:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-12 12:01:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 12:01:18]

Try jobs failed on following builders:
  win_x64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/21601)

[sprang_webrtc, 2017-01-12 12:20:16]

updated tests, ptal

[danilchap, 2017-01-12 12:27:51]

looks good

https://codereview.webrtc.org/2625893004/diff/40001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2625893004/diff/40001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:3081: const bool is_screenshare_;
may be rename to enable_target_bitrate_
to match variable above and be more explicit what scenario this variable tests.

[sprang_webrtc, 2017-01-12 12:43:08]

https://codereview.webrtc.org/2625893004/diff/40001/webrtc/video/end_to_end_t...
File webrtc/video/end_to_end_tests.cc (right):

https://codereview.webrtc.org/2625893004/diff/40001/webrtc/video/end_to_end_t...
webrtc/video/end_to_end_tests.cc:3081: const bool is_screenshare_;
On 2017/01/12 12:27:51, danilchap wrote:
> may be rename to enable_target_bitrate_
> to match variable above and be more explicit what scenario this variable
tests.

Done.

[sprang_webrtc, 2017-01-13 13:15:28]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2017-01-13 13:15:28]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2625893004/#ps60001 (title:
"Renamed parameter")

[commit-bot: I haz the power, 2017-01-13 13:15:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-13 15:30:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484313328458500,
"parent_rev": "36e7d704100d632799f32344fb125e2944172c78", "commit_rev":
"44b3ef65ed562aec042c0f1d29a983207228e40e"}

[commit-bot: I haz the power, 2017-01-13 15:30:27]

Description was changed from

==========
Signal target bitrate only for screenshare streams

BUG=webrtc:6301
==========

to

==========
Signal target bitrate only for screenshare streams

BUG=webrtc:6301

Review-Url: https://codereview.webrtc.org/2625893004
Cr-Commit-Position: refs/heads/master@{#16058}
Committed:
https://chromium.googlesource.com/external/webrtc/+/44b3ef65ed562aec042c0f1d2...
==========

[commit-bot: I haz the power, 2017-01-13 15:30:28]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/44b3ef65ed562aec042c0f1d2...