Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: webrtc/video/video_send_stream.cc

Issue 2625893004: Signal target bitrate only for screenshare streams (Closed)
Patch Set: Renamed parameter Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/end_to_end_tests.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream.cc
diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc
index 6dc68484d118da216a0d24116c5f99ff0ce0bab5..41f8b3f3676e958d8b7f493a248cc2f054eb36fc 100644
--- a/webrtc/video/video_send_stream.cc
+++ b/webrtc/video/video_send_stream.cc
@@ -617,7 +617,11 @@ VideoSendStream::VideoSendStream(
// it was created on.
thread_sync_event_.Wait(rtc::Event::kForever);
send_stream_->RegisterProcessThread(module_process_thread);
- vie_encoder_->SetBitrateObserver(send_stream_.get());
+ // TODO(sprang): Enable this also for regular video calls if it works well.
+ if (encoder_config.content_type == VideoEncoderConfig::ContentType::kScreen) {
+ // Only signal target bitrate for screenshare streams, for now.
+ vie_encoder_->SetBitrateObserver(send_stream_.get());
+ }
vie_encoder_->RegisterProcessThread(module_process_thread);
ReconfigureVideoEncoder(std::move(encoder_config));
« no previous file with comments | « webrtc/video/end_to_end_tests.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698