webrtc/media/base/fakemediaengine.h - Issue 2623473004: Replace all use of the VERIFY macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/base/fakemediaengine.h

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)

Patch Set: Delete a DCHECK, instead log and return failure. And fix compile error in previous patch set. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/media/base/fakemediaengine.h

diff --git a/webrtc/media/base/fakemediaengine.h b/webrtc/media/base/fakemediaengine.h

index 11909659eabbab5fd59f782f7852cd80b8eebf4d..2b774b2bb98ecad54a32ead95f44da6308173cf5 100644

--- a/webrtc/media/base/fakemediaengine.h

+++ b/webrtc/media/base/fakemediaengine.h

@@ -469,7 +469,7 @@ class FakeVoiceMediaChannel : public RtpHelper<VoiceMediaChannel> {

auto it = local_sinks_.find(ssrc);

if (source) {

if (it != local_sinks_.end()) {

- RTC_DCHECK(it->second->source() == source);

+ RTC_CHECK(it->second->source() == source);

} else {

local_sinks_.insert(

std::make_pair(ssrc, new VoiceChannelAudioSink(source)));