webrtc/examples/peerconnection/client/peer_connection_client.cc - Issue 2623473004: Replace all use of the VERIFY macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/peerconnection/client/peer_connection_client.cc

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)

Patch Set: Delete a DCHECK, instead log and return failure. And fix compile error in previous patch set. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/examples/peerconnection/client/peer_connection_client.cc

diff --git a/webrtc/examples/peerconnection/client/peer_connection_client.cc b/webrtc/examples/peerconnection/client/peer_connection_client.cc

index 5cdce087c13f056c13bec168de0af3ea8ff15d20..ab9cd328ba559f21c998661d541c83ae790669f1 100644

--- a/webrtc/examples/peerconnection/client/peer_connection_client.cc

+++ b/webrtc/examples/peerconnection/client/peer_connection_client.cc

@@ -238,7 +238,6 @@ void PeerConnectionClient::OnConnect(rtc::AsyncSocket* socket) {

RTC_DCHECK(!onconnect_data_.empty());

size_t sent = socket->Send(onconnect_data_.c_str(), onconnect_data_.length());

RTC_DCHECK(sent == onconnect_data_.length());

- RTC_UNUSED(sent);

onconnect_data_.clear();

}

@@ -249,7 +248,6 @@ void PeerConnectionClient::OnHangingGetConnect(rtc::AsyncSocket* socket) {

int len = static_cast<int>(strlen(buffer));

int sent = socket->Send(buffer, len);

RTC_DCHECK(sent == len);

- RTC_UNUSED2(sent, len);

}

void PeerConnectionClient::OnMessageFromPeer(int peer_id,