webrtc/pc/webrtcsdp.cc - Issue 2623473004: Replace all use of the VERIFY macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/webrtcsdp.cc

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)

Patch Set: Delete a DCHECK, instead log and return failure. And fix compile error in previous patch set. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/pc/webrtcsdp.cc

diff --git a/webrtc/pc/webrtcsdp.cc b/webrtc/pc/webrtcsdp.cc

index 11eefe5c3d5098f88ce8a884c5535d7dd14248cf..d5110fc8542a37570a9b6ece207226935ab98f27 100644

--- a/webrtc/pc/webrtcsdp.cc

+++ b/webrtc/pc/webrtcsdp.cc

@@ -1376,7 +1376,9 @@ void BuildMediaDescription(const ContentInfo* content_info,

cricket::ConnectionRole role =

transport_info->description.connection_role;

std::string dtls_role_str;

- VERIFY(cricket::ConnectionRoleToString(role, &dtls_role_str));

+ const bool success =

+ cricket::ConnectionRoleToString(role, &dtls_role_str);

+ RTC_DCHECK(success);

kwiberg-webrtc 2017/02/07 14:08:05 :-)

InitAttrLine(kAttributeSetup, &os);

os << kSdpDelimiterColon << dtls_role_str;

AddLine(os.str(), message);

« no previous file with comments | « webrtc/pc/mediasession.cc ('k') | no next file » | no next file with comments »