Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Side by Side Diff: webrtc/pc/webrtcsdp.cc

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)
Patch Set: Delete a DCHECK, instead log and return failure. And fix compile error in previous patch set. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/mediasession.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2011 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1358 matching lines...) Expand 10 before | Expand all | Expand 10 after
1369 << fp->GetRfc4572Fingerprint(); 1369 << fp->GetRfc4572Fingerprint();
1370 AddLine(os.str(), message); 1370 AddLine(os.str(), message);
1371 1371
1372 // Inserting setup attribute. 1372 // Inserting setup attribute.
1373 if (transport_info->description.connection_role != 1373 if (transport_info->description.connection_role !=
1374 cricket::CONNECTIONROLE_NONE) { 1374 cricket::CONNECTIONROLE_NONE) {
1375 // Making sure we are not using "passive" mode. 1375 // Making sure we are not using "passive" mode.
1376 cricket::ConnectionRole role = 1376 cricket::ConnectionRole role =
1377 transport_info->description.connection_role; 1377 transport_info->description.connection_role;
1378 std::string dtls_role_str; 1378 std::string dtls_role_str;
1379 VERIFY(cricket::ConnectionRoleToString(role, &dtls_role_str)); 1379 const bool success =
1380 cricket::ConnectionRoleToString(role, &dtls_role_str);
1381 RTC_DCHECK(success);
kwiberg-webrtc 2017/02/07 14:08:05 :-)
1380 InitAttrLine(kAttributeSetup, &os); 1382 InitAttrLine(kAttributeSetup, &os);
1381 os << kSdpDelimiterColon << dtls_role_str; 1383 os << kSdpDelimiterColon << dtls_role_str;
1382 AddLine(os.str(), message); 1384 AddLine(os.str(), message);
1383 } 1385 }
1384 } 1386 }
1385 } 1387 }
1386 1388
1387 // RFC 3388 1389 // RFC 3388
1388 // mid-attribute = "a=mid:" identification-tag 1390 // mid-attribute = "a=mid:" identification-tag
1389 // identification-tag = token 1391 // identification-tag = token
(...skipping 1801 matching lines...) Expand 10 before | Expand all | Expand 10 after
3191 UpdateCodec<AudioContentDescription, cricket::AudioCodec>( 3193 UpdateCodec<AudioContentDescription, cricket::AudioCodec>(
3192 media_desc, payload_type, feedback_param); 3194 media_desc, payload_type, feedback_param);
3193 } else if (media_type == cricket::MEDIA_TYPE_VIDEO) { 3195 } else if (media_type == cricket::MEDIA_TYPE_VIDEO) {
3194 UpdateCodec<VideoContentDescription, cricket::VideoCodec>( 3196 UpdateCodec<VideoContentDescription, cricket::VideoCodec>(
3195 media_desc, payload_type, feedback_param); 3197 media_desc, payload_type, feedback_param);
3196 } 3198 }
3197 return true; 3199 return true;
3198 } 3200 }
3199 3201
3200 } // namespace webrtc 3202 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/pc/mediasession.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698