webrtc/base/socketadapters.cc - Issue 2623473004: Replace all use of the VERIFY macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/socketadapters.cc

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)

Patch Set: Delete a DCHECK, instead log and return failure. And fix compile error in previous patch set. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/socketadapters.cc

diff --git a/webrtc/base/socketadapters.cc b/webrtc/base/socketadapters.cc

index 0a9498261339e7cc1385abd65b449c71addb0b12..f6029ce964545695e99c93288720922e7ec0338a 100644

--- a/webrtc/base/socketadapters.cc

+++ b/webrtc/base/socketadapters.cc

@@ -185,8 +185,8 @@ int AsyncSSLSocket::Connect(const SocketAddress& addr) {

void AsyncSSLSocket::OnConnectEvent(AsyncSocket * socket) {

RTC_DCHECK(socket == socket_);

// TODO: we could buffer output too...

- VERIFY(sizeof(kSslClientHello) ==

- DirectSend(kSslClientHello, sizeof(kSslClientHello)));

+ const int res = DirectSend(kSslClientHello, sizeof(kSslClientHello));

+ RTC_DCHECK_EQ(sizeof(kSslClientHello), res);

}

void AsyncSSLSocket::ProcessInput(char* data, size_t* len) {