webrtc/base/signalthread.h - Issue 2623473004: Replace all use of the VERIFY macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/signalthread.h

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)

Patch Set: Delete a DCHECK, instead log and return failure. And fix compile error in previous patch set. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/base/signalthread.h

diff --git a/webrtc/base/signalthread.h b/webrtc/base/signalthread.h

index befb02fb5befa20377a9502dbef23f53342e406e..a91e4ad34ae8162175edaba062b7e1b3d3db798e 100644

--- a/webrtc/base/signalthread.h

+++ b/webrtc/base/signalthread.h

@@ -125,7 +125,7 @@ class SignalThread

t_->cs_.Enter();

// If refcount_ is zero then the object has already been deleted and we

// will be double-deleting it in ~EnterExit()! (shouldn't happen)

- RTC_DCHECK(t_->refcount_ != 0);

+ RTC_DCHECK_NE(0, t_->refcount_);

++t_->refcount_;

}

~EnterExit() UNLOCK_FUNCTION() {