Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: webrtc/base/win32window.cc

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)
Patch Set: Tweaks after reviewing diff to master. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/win32window.cc
diff --git a/webrtc/base/win32window.cc b/webrtc/base/win32window.cc
index daa7688554863a26d772e36738e93f87c825fefc..681e51b2becaae071ab9dd2df6fce7c7c194d9ba 100644
--- a/webrtc/base/win32window.cc
+++ b/webrtc/base/win32window.cc
@@ -9,7 +9,6 @@
*/
#include "webrtc/base/checks.h"
-#include "webrtc/base/common.h"
#include "webrtc/base/logging.h"
#include "webrtc/base/win32window.h"
@@ -65,7 +64,8 @@ bool Win32Window::Create(HWND parent, const wchar_t* title, DWORD style,
}
void Win32Window::Destroy() {
- VERIFY(::DestroyWindow(wnd_) != FALSE);
+ bool res = (::DestroyWindow(wnd_) != FALSE);
+ RTC_DCHECK(res);
kwiberg-webrtc 2017/02/07 09:39:49 Or const XXX res = ::DestroyWindow(wnd_); RTC
nisse-webrtc 2017/02/07 10:48:15 I think I'll instead write it as const bool succe
kwiberg-webrtc 2017/02/07 11:45:08 Excellent.
}
void Win32Window::Shutdown() {

Powered by Google App Engine
This is Rietveld 408576698