Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: webrtc/base/sslstreamadapter_unittest.cc

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)
Patch Set: Tweaks after reviewing diff to master. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/sslstreamadapter_unittest.cc
diff --git a/webrtc/base/sslstreamadapter_unittest.cc b/webrtc/base/sslstreamadapter_unittest.cc
index 82036913e0ea7eaedc7ef134409a6a37767d1a61..d256f8c38b9f113e9d1d4eb26430885125386271 100644
--- a/webrtc/base/sslstreamadapter_unittest.cc
+++ b/webrtc/base/sslstreamadapter_unittest.cc
@@ -377,7 +377,9 @@ class SSLStreamAdapterTestBase : public testing::Test,
// Make sure we simulate a reliable network for TLS.
// This is just a check to make sure that people don't write wrong
// tests.
- RTC_CHECK((mtu_ == 1460) && (loss_ == 0) && (lose_first_packet_ == 0));
+ RTC_CHECK_EQ(mtu_, 1460u);
kwiberg-webrtc 2017/02/07 09:39:49 Drop the "u".
nisse-webrtc 2017/02/07 10:48:15 Done.
+ RTC_CHECK_EQ(loss_, 0);
+ RTC_CHECK_EQ(lose_first_packet_, 0);
nisse-webrtc 2017/02/07 10:48:15 And these two are bools, not numbers. So changing
}
if (!identities_set_)
@@ -414,7 +416,9 @@ class SSLStreamAdapterTestBase : public testing::Test,
// Make sure we simulate a reliable network for TLS.
// This is just a check to make sure that people don't write wrong
// tests.
- RTC_CHECK((mtu_ == 1460) && (loss_ == 0) && (lose_first_packet_ == 0));
+ RTC_CHECK_EQ(mtu_, 1460u);
kwiberg-webrtc 2017/02/07 09:39:49 Again, no "u".
nisse-webrtc 2017/02/07 10:48:15 Done.
+ RTC_CHECK_EQ(loss_, 0);
+ RTC_CHECK_EQ(lose_first_packet_, 0);
}
// Start the handshake

Powered by Google App Engine
This is Rietveld 408576698