Replace all use of the VERIFY macro.

webrtc/base/win32window.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/base/checks.h"
-#include "webrtc/base/common.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/win32window.h"
 
 namespace rtc {
 
 ///////////////////////////////////////////////////////////////////////////////
 // Win32Window
 ///////////////////////////////////////////////////////////////////////////////
 
 static const wchar_t kWindowBaseClassName[] = L"WindowBaseClass";
@@ skipping 35 matching lines @@
       LOG_GLE(LS_ERROR) << "RegisterClassEx failed";
       return false;
     }
   }
   wnd_ = ::CreateWindowEx(exstyle, kWindowBaseClassName, title, style,
                           x, y, cx, cy, parent, NULL, instance_, this);
   return (NULL != wnd_);
 }
 
 void Win32Window::Destroy() {
-  VERIFY(::DestroyWindow(wnd_) != FALSE);
+  bool res = (::DestroyWindow(wnd_) != FALSE);
+  RTC_DCHECK(res);

[kwiberg-webrtc, 2017/02/07 09:39:49]

Or

  const XXX res = ::DestroyWindow(wnd_);
  RTC_DCHECK_NE(FALSE, res);

That's one less indirection in the boolean logic. Because I'm lazy, and I like
it when code doesn't require me to think too much...

[nisse-webrtc, 2017/02/07 10:48:15]

I think I'll instead write it as

const bool success = ::DestroyWindow(...);
RTC_DCHECK(success);

I think that's clearer than using the FALSE constant.

I know close to nothing about windows programming, but according to the docs
(https://msdn.microsoft.com/en-us/library/windows/desktop/ms632682(v=vs.85).aspx),
the return type is the windows type BOOL which seems to be numeric, and it's
documented to be non-zero on success and zero on failure. So then implicit
conversion to bool should do the right thing.

BTW, do you want me to rename other "res" variables to "success" too?

[kwiberg-webrtc, 2017/02/07 11:45:08]

Excellent.
If it makes sense (i.e., if they're boolean, and true means successful), then
yes, that's probably a good idea. Some people are allergic to "res" variables,
but I'm not one of them.

 }
 
 void Win32Window::Shutdown() {
   if (window_class_) {
     ::UnregisterClass(MAKEINTATOM(window_class_), instance_);
     window_class_ = 0;
   }
 }
 
 bool Win32Window::OnMessage(UINT uMsg, WPARAM wParam, LPARAM lParam,
@@ skipping 34 matching lines @@
       that->OnNcDestroy();
     }
     if (handled) {
       return result;
     }
   }
   return ::DefWindowProc(hwnd, uMsg, wParam, lParam);
 }
 
 }  // namespace rtc