Remove FlexfecConfig and replace with specific struct in VideoSendStream.

Remove FlexfecConfig and replace with specific struct in VideoSendStream.

The existence of FlexfecConfig is due to a naive design. Now when it
is not used on the receiving side (see https://codereview.webrtc.org/2542413002),
it is time to remove it from the sending side as well.

BUG=webrtc:5654
Review-Url: https://codereview.webrtc.org/2621573002
Cr-Commit-Position: refs/heads/master@{#16097}
Committed: https://chromium.googlesource.com/external/webrtc/+/3d200bd6ac61437ed8808ed395d425c71c829c4a

[brandtr, 2017-01-09 08:22:19]

Patchset #1 (id:1) has been deleted

[brandtr, 2017-01-09 11:44:24]

brandtr@webrtc.org changed reviewers:
+ philipel@webrtc.org, stefan@webrtc.org

[stefan-webrtc, 2017-01-10 11:43:25]

lgtm % comment

https://codereview.webrtc.org/2621573002/diff/20001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2621573002/diff/20001/webrtc/video/video_send_s...
webrtc/video/video_send_stream.cc:192: ss << flexfec.protected_media_ssrcs[i];
Write this code in a similar fashion as line 175-179

[brandtr, 2017-01-10 12:17:27]

Thanks for feedback.

https://codereview.webrtc.org/2621573002/diff/20001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2621573002/diff/20001/webrtc/video/video_send_s...
webrtc/video/video_send_stream.cc:192: ss << flexfec.protected_media_ssrcs[i];
On 2017/01/10 11:43:25, stefan-webrtc wrote:
> Write this code in a similar fashion as line 175-179

Done.

Need to land https://codereview.webrtc.org/2589713003/ before landing this
change.

[brandtr, 2017-01-12 15:00:02]

Rebase.

[brandtr, 2017-01-16 10:26:51]

Rebase.

[brandtr, 2017-01-16 12:56:00]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 12:56:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[brandtr, 2017-01-16 14:35:01]

The CQ bit was unchecked by brandtr@webrtc.org

[brandtr, 2017-01-16 14:35:05]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2017-01-16 14:35:05]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2621573002/#ps80001 (title:
"Rebase.")

[commit-bot: I haz the power, 2017-01-16 14:35:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-16 14:59:20]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484577305358490,
"parent_rev": "57c2fff361fac137480a3b045d2c6b194b1d0d30", "commit_rev":
"3d200bd6ac61437ed8808ed395d425c71c829c4a"}

[commit-bot: I haz the power, 2017-01-16 14:59:24]

Description was changed from

==========
Remove FlexfecConfig and replace with specific struct in VideoSendStream.

The existence of FlexfecConfig is due to a naive design. Now when it
is not used on the receiving side (see
https://codereview.webrtc.org/2542413002),
it is time to remove it from the sending side as well.

BUG=webrtc:5654
==========

to

==========
Remove FlexfecConfig and replace with specific struct in VideoSendStream.

The existence of FlexfecConfig is due to a naive design. Now when it
is not used on the receiving side (see
https://codereview.webrtc.org/2542413002),
it is time to remove it from the sending side as well.

BUG=webrtc:5654

Review-Url: https://codereview.webrtc.org/2621573002
Cr-Commit-Position: refs/heads/master@{#16097}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3d200bd6ac61437ed8808ed39...
==========

[commit-bot: I haz the power, 2017-01-16 14:59:24]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/3d200bd6ac61437ed8808ed39...