Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 2621573002: Remove FlexfecConfig and replace with specific struct in VideoSendStream. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/test/call_test.cc ('k') | webrtc/video/send_statistics_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 3846 matching lines...) Expand 10 before | Expand all | Expand 10 after
3857 3857
3858 void VerifyEmptyUlpfecConfig(const UlpfecConfig& config) { 3858 void VerifyEmptyUlpfecConfig(const UlpfecConfig& config) {
3859 EXPECT_EQ(-1, config.ulpfec_payload_type) 3859 EXPECT_EQ(-1, config.ulpfec_payload_type)
3860 << "Enabling ULPFEC requires rtpmap: ulpfec negotiation."; 3860 << "Enabling ULPFEC requires rtpmap: ulpfec negotiation.";
3861 EXPECT_EQ(-1, config.red_payload_type) 3861 EXPECT_EQ(-1, config.red_payload_type)
3862 << "Enabling ULPFEC requires rtpmap: red negotiation."; 3862 << "Enabling ULPFEC requires rtpmap: red negotiation.";
3863 EXPECT_EQ(-1, config.red_rtx_payload_type) 3863 EXPECT_EQ(-1, config.red_rtx_payload_type)
3864 << "Enabling RTX in ULPFEC requires rtpmap: rtx negotiation."; 3864 << "Enabling RTX in ULPFEC requires rtpmap: rtx negotiation.";
3865 } 3865 }
3866 3866
3867 void VerifyEmptyFlexfecConfig(const FlexfecConfig& config) { 3867 void VerifyEmptyFlexfecConfig(
3868 EXPECT_EQ(-1, config.flexfec_payload_type) 3868 const VideoSendStream::Config::Rtp::Flexfec& config) {
3869 EXPECT_EQ(-1, config.payload_type)
3869 << "Enabling FlexFEC requires rtpmap: flexfec negotiation."; 3870 << "Enabling FlexFEC requires rtpmap: flexfec negotiation.";
3870 EXPECT_EQ(0U, config.flexfec_ssrc) 3871 EXPECT_EQ(0U, config.ssrc)
3871 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation."; 3872 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation.";
3872 EXPECT_TRUE(config.protected_media_ssrcs.empty()) 3873 EXPECT_TRUE(config.protected_media_ssrcs.empty())
3873 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation."; 3874 << "Enabling FlexFEC requires ssrc-group: FEC-FR negotiation.";
3874 } 3875 }
3875 3876
3876 TEST_P(EndToEndTest, VerifyDefaultSendConfigParameters) { 3877 TEST_P(EndToEndTest, VerifyDefaultSendConfigParameters) {
3877 VideoSendStream::Config default_send_config(nullptr); 3878 VideoSendStream::Config default_send_config(nullptr);
3878 EXPECT_EQ(0, default_send_config.rtp.nack.rtp_history_ms) 3879 EXPECT_EQ(0, default_send_config.rtp.nack.rtp_history_ms)
3879 << "Enabling NACK require rtcp-fb: nack negotiation."; 3880 << "Enabling NACK require rtcp-fb: nack negotiation.";
3880 EXPECT_TRUE(default_send_config.rtp.rtx.ssrcs.empty()) 3881 EXPECT_TRUE(default_send_config.rtp.rtx.ssrcs.empty())
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
4083 std::unique_ptr<VideoEncoder> encoder_; 4084 std::unique_ptr<VideoEncoder> encoder_;
4084 std::unique_ptr<VideoDecoder> decoder_; 4085 std::unique_ptr<VideoDecoder> decoder_;
4085 rtc::CriticalSection crit_; 4086 rtc::CriticalSection crit_;
4086 int recorded_frames_ GUARDED_BY(crit_); 4087 int recorded_frames_ GUARDED_BY(crit_);
4087 } test(this); 4088 } test(this);
4088 4089
4089 RunBaseTest(&test); 4090 RunBaseTest(&test);
4090 } 4091 }
4091 4092
4092 } // namespace webrtc 4093 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/test/call_test.cc ('k') | webrtc/video/send_statistics_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698