Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2618693002: Reland of move webrtc/libjingle/{xmllite,xmpp} (Closed)

Created:
3 years, 11 months ago by kjellander_webrtc
Modified:
3 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of "Remove webrtc/libjingle/{xmllite,xmpp}" Last references to the old code were fixed in Chromium with https://codereview.chromium.org/2616873002/ and https://codereview.chromium.org/2617363002/ Original issue's description: > Revert of Remove webrtc/libjingle/{xmllite,xmpp} (patchset #1 id:1 of https://codereview.webrtc.org/2617443003/ ) > > Reason for revert: > Breaks Chromium FYI bots. > > tommi, please let me land this (I forgot to run them). > > Original issue's description: > > Remove webrtc/libjingle/{xmllite,xmpp} as it's dead code. > > > > These sources have now been imported into Chromium's > > src/third_party/libjingle_xmpp. > > > > BUG=webrtc:5539 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2617443003 > > Cr-Commit-Position: refs/heads/master@{#15910} > > Committed: https://chromium.googlesource.com/external/webrtc/+/1670b1fe6bbc8f63b039782979beaeefa215faac > > TBR=tommi@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5539 > > Review-Url: https://codereview.webrtc.org/2618633003 > Cr-Commit-Position: refs/heads/master@{#15911} > Committed: https://chromium.googlesource.com/external/webrtc/+/60ef117be4b0ebceba94f8fe926f1314fe02721e TBR=tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5539 Review-Url: https://codereview.webrtc.org/2618693002 Cr-Commit-Position: refs/heads/master@{#15954} Committed: https://chromium.googlesource.com/external/webrtc/+/13ced17068aa440028aa39954c5426c2e162d0d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19602 lines) Patch
M webrtc/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/build/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download
D webrtc/libjingle/BUILD.gn View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/libjingle/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/libjingle/OWNERS View 1 chunk +0 lines, -10 lines 0 comments Download
D webrtc/libjingle/xmllite/BUILD.gn View 1 chunk +0 lines, -51 lines 0 comments Download
D webrtc/libjingle/xmllite/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/libjingle/xmllite/qname.h View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/libjingle/xmllite/qname.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D webrtc/libjingle/xmllite/qname_unittest.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlbuilder.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlbuilder.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlbuilder_unittest.cc View 1 chunk +0 lines, -177 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlconstants.h View 1 chunk +0 lines, -30 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlconstants.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlelement.h View 1 chunk +0 lines, -233 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlelement.cc View 1 chunk +0 lines, -496 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlelement_unittest.cc View 1 chunk +0 lines, -258 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlnsstack.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlnsstack.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlnsstack_unittest.cc View 1 chunk +0 lines, -241 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlparser.h View 1 chunk +0 lines, -103 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlparser.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlparser_unittest.cc View 1 chunk +0 lines, -285 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlprinter.h View 1 chunk +0 lines, -32 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlprinter.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D webrtc/libjingle/xmllite/xmlprinter_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/libjingle/xmpp/BUILD.gn View 1 chunk +0 lines, -154 lines 0 comments Download
D webrtc/libjingle/xmpp/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/libjingle/xmpp/asyncsocket.h View 1 chunk +0 lines, -72 lines 0 comments Download
D webrtc/libjingle/xmpp/chatroommodule.h View 1 chunk +0 lines, -253 lines 0 comments Download
D webrtc/libjingle/xmpp/chatroommoduleimpl.cc View 1 chunk +0 lines, -737 lines 0 comments Download
D webrtc/libjingle/xmpp/constants.h View 1 chunk +0 lines, -551 lines 0 comments Download
D webrtc/libjingle/xmpp/constants.cc View 1 chunk +0 lines, -613 lines 0 comments Download
D webrtc/libjingle/xmpp/discoitemsquerytask.h View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/libjingle/xmpp/discoitemsquerytask.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/libjingle/xmpp/fakexmppclient.h View 1 chunk +0 lines, -107 lines 0 comments Download
D webrtc/libjingle/xmpp/hangoutpubsubclient.h View 1 chunk +0 lines, -178 lines 0 comments Download
D webrtc/libjingle/xmpp/hangoutpubsubclient.cc View 1 chunk +0 lines, -400 lines 0 comments Download
D webrtc/libjingle/xmpp/hangoutpubsubclient_unittest.cc View 1 chunk +0 lines, -754 lines 0 comments Download
D webrtc/libjingle/xmpp/iqtask.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webrtc/libjingle/xmpp/iqtask.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D webrtc/libjingle/xmpp/jid.h View 1 chunk +0 lines, -80 lines 0 comments Download
D webrtc/libjingle/xmpp/jid.cc View 1 chunk +0 lines, -379 lines 0 comments Download
D webrtc/libjingle/xmpp/jid_unittest.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D webrtc/libjingle/xmpp/module.h View 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/libjingle/xmpp/moduleimpl.h View 1 chunk +0 lines, -76 lines 0 comments Download
D webrtc/libjingle/xmpp/moduleimpl.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomconfigtask.h View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomconfigtask.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomconfigtask_unittest.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomdiscoverytask.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomdiscoverytask.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomdiscoverytask_unittest.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomlookuptask.h View 1 chunk +0 lines, -76 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomlookuptask.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomlookuptask_unittest.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomuniquehangoutidtask.h View 1 chunk +0 lines, -38 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomuniquehangoutidtask.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D webrtc/libjingle/xmpp/mucroomuniquehangoutidtask_unittest.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D webrtc/libjingle/xmpp/pingtask.h View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/libjingle/xmpp/pingtask.cc View 1 chunk +0 lines, -93 lines 0 comments Download
D webrtc/libjingle/xmpp/pingtask_unittest.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D webrtc/libjingle/xmpp/plainsaslhandler.h View 1 chunk +0 lines, -64 lines 0 comments Download
D webrtc/libjingle/xmpp/presenceouttask.h View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/libjingle/xmpp/presenceouttask.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D webrtc/libjingle/xmpp/presencereceivetask.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/libjingle/xmpp/presencereceivetask.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D webrtc/libjingle/xmpp/presencestatus.h View 1 chunk +0 lines, -188 lines 0 comments Download
D webrtc/libjingle/xmpp/presencestatus.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/libjingle/xmpp/prexmppauth.h View 1 chunk +0 lines, -71 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsub_task.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsub_task.cc View 1 chunk +0 lines, -201 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsubclient.h View 1 chunk +0 lines, -111 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsubclient.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsubclient_unittest.cc View 1 chunk +0 lines, -279 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsubstateclient.h View 1 chunk +0 lines, -271 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsubstateclient.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsubtasks.h View 1 chunk +0 lines, -114 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsubtasks.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D webrtc/libjingle/xmpp/pubsubtasks_unittest.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D webrtc/libjingle/xmpp/receivetask.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webrtc/libjingle/xmpp/receivetask.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D webrtc/libjingle/xmpp/rostermodule.h View 1 chunk +0 lines, -331 lines 0 comments Download
D webrtc/libjingle/xmpp/rostermodule_unittest.cc View 1 chunk +0 lines, -832 lines 0 comments Download
D webrtc/libjingle/xmpp/rostermoduleimpl.h View 1 chunk +0 lines, -287 lines 0 comments Download
D webrtc/libjingle/xmpp/rostermoduleimpl.cc View 1 chunk +0 lines, -1064 lines 0 comments Download
D webrtc/libjingle/xmpp/saslcookiemechanism.h View 1 chunk +0 lines, -69 lines 0 comments Download
D webrtc/libjingle/xmpp/saslhandler.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webrtc/libjingle/xmpp/saslmechanism.h View 1 chunk +0 lines, -57 lines 0 comments Download
D webrtc/libjingle/xmpp/saslmechanism.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D webrtc/libjingle/xmpp/saslplainmechanism.h View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/libjingle/xmpp/util_unittest.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/libjingle/xmpp/util_unittest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppauth.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppauth.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppclient.h View 1 chunk +0 lines, -149 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppclient.cc View 1 chunk +0 lines, -423 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppclientsettings.h View 1 chunk +0 lines, -111 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppengine.h View 1 chunk +0 lines, -332 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppengine_unittest.cc View 1 chunk +0 lines, -327 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppengineimpl.h View 1 chunk +0 lines, -267 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppengineimpl.cc View 1 chunk +0 lines, -446 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppengineimpl_iq.cc View 1 chunk +0 lines, -260 lines 0 comments Download
D webrtc/libjingle/xmpp/xmpplogintask.h View 1 chunk +0 lines, -87 lines 0 comments Download
D webrtc/libjingle/xmpp/xmpplogintask.cc View 1 chunk +0 lines, -380 lines 0 comments Download
D webrtc/libjingle/xmpp/xmpplogintask_unittest.cc View 1 chunk +0 lines, -637 lines 0 comments Download
D webrtc/libjingle/xmpp/xmpppump.h View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/libjingle/xmpp/xmpppump.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppsocket.h View 1 chunk +0 lines, -72 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppsocket.cc View 1 chunk +0 lines, -246 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppstanzaparser.h View 1 chunk +0 lines, -80 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppstanzaparser.cc View 1 chunk +0 lines, -89 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppstanzaparser_unittest.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D webrtc/libjingle/xmpp/xmpptask.h View 1 chunk +0 lines, -175 lines 0 comments Download
D webrtc/libjingle/xmpp/xmpptask.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppthread.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webrtc/libjingle/xmpp/xmppthread.cc View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kjellander_webrtc
Created Reland of move webrtc/libjingle/{xmllite,xmpp}
3 years, 11 months ago (2017-01-05 10:54:44 UTC) #1
kjellander_webrtc
On 2017/01/05 10:54:44, kjellander_webrtc wrote: > Created Reland of move webrtc/libjingle/{xmllite,xmpp} Ah, trybots fail due ...
3 years, 11 months ago (2017-01-09 05:42:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2618693002/1
3 years, 11 months ago (2017-01-09 06:01:39 UTC) #4
kjellander_webrtc
On 2017/01/09 06:01:39, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 11 months ago (2017-01-09 06:07:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2618693002/1
3 years, 11 months ago (2017-01-09 07:01:39 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 07:02:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/13ced17068aa440028aa39954...

Powered by Google App Engine
This is Rietveld 408576698