Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 2618633003: Revert of Remove webrtc/libjingle/{xmllite,xmpp} (Closed)

Created:
3 years, 11 months ago by kjellander_webrtc
Modified:
3 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove webrtc/libjingle/{xmllite,xmpp} (patchset #1 id:1 of https://codereview.webrtc.org/2617443003/ ) Reason for revert: Breaks Chromium FYI bots. tommi, please let me land this (I forgot to run them). Original issue's description: > Remove webrtc/libjingle/{xmllite,xmpp} as it's dead code. > > These sources have now been imported into Chromium's > src/third_party/libjingle_xmpp. > > BUG=webrtc:5539 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2617443003 > Cr-Commit-Position: refs/heads/master@{#15910} > Committed: https://chromium.googlesource.com/external/webrtc/+/1670b1fe6bbc8f63b039782979beaeefa215faac TBR=tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5539 Review-Url: https://codereview.webrtc.org/2618633003 Cr-Commit-Position: refs/heads/master@{#15911} Committed: https://chromium.googlesource.com/external/webrtc/+/60ef117be4b0ebceba94f8fe926f1314fe02721e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19602 lines, -0 lines) Patch
M webrtc/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/build/gn_isolate_map.pyl View 1 chunk +4 lines, -0 lines 0 comments Download
A webrtc/libjingle/BUILD.gn View 1 chunk +59 lines, -0 lines 0 comments Download
A webrtc/libjingle/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/libjingle/OWNERS View 1 chunk +10 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/BUILD.gn View 1 chunk +51 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/qname.h View 1 chunk +83 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/qname.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/qname_unittest.cc View 1 chunk +114 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlbuilder.h View 1 chunk +61 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlbuilder.cc View 1 chunk +130 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlbuilder_unittest.cc View 1 chunk +177 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlconstants.h View 1 chunk +30 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlconstants.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlelement.h View 1 chunk +233 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlelement.cc View 1 chunk +496 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlelement_unittest.cc View 1 chunk +258 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlnsstack.h View 1 chunk +45 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlnsstack.cc View 1 chunk +178 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlnsstack_unittest.cc View 1 chunk +241 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlparser.h View 1 chunk +103 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlparser.cc View 1 chunk +261 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlparser_unittest.cc View 1 chunk +285 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlprinter.h View 1 chunk +32 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlprinter.cc View 1 chunk +174 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmllite/xmlprinter_unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/BUILD.gn View 1 chunk +154 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/asyncsocket.h View 1 chunk +72 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/chatroommodule.h View 1 chunk +253 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/chatroommoduleimpl.cc View 1 chunk +737 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/constants.h View 1 chunk +551 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/constants.cc View 1 chunk +613 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/discoitemsquerytask.h View 1 chunk +65 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/discoitemsquerytask.cc View 1 chunk +61 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/fakexmppclient.h View 1 chunk +107 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/hangoutpubsubclient.h View 1 chunk +178 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/hangoutpubsubclient.cc View 1 chunk +400 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/hangoutpubsubclient_unittest.cc View 1 chunk +754 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/iqtask.h View 1 chunk +49 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/iqtask.cc View 1 chunk +69 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/jid.h View 1 chunk +80 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/jid.cc View 1 chunk +379 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/jid_unittest.cc View 1 chunk +122 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/module.h View 1 chunk +35 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/moduleimpl.h View 1 chunk +76 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/moduleimpl.cc View 1 chunk +48 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomconfigtask.h View 1 chunk +47 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomconfigtask.cc View 1 chunk +73 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomconfigtask_unittest.cc View 1 chunk +127 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomdiscoverytask.h View 1 chunk +41 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomdiscoverytask.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomdiscoverytask_unittest.cc View 1 chunk +145 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomlookuptask.h View 1 chunk +76 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomlookuptask.cc View 1 chunk +158 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomlookuptask_unittest.cc View 1 chunk +187 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomuniquehangoutidtask.h View 1 chunk +38 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomuniquehangoutidtask.cc View 1 chunk +51 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/mucroomuniquehangoutidtask_unittest.cc View 1 chunk +99 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pingtask.h View 1 chunk +55 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pingtask.cc View 1 chunk +93 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pingtask_unittest.cc View 1 chunk +101 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/plainsaslhandler.h View 1 chunk +64 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/presenceouttask.h View 1 chunk +37 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/presenceouttask.cc View 1 chunk +141 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/presencereceivetask.h View 1 chunk +56 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/presencereceivetask.cc View 1 chunk +141 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/presencestatus.h View 1 chunk +188 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/presencestatus.cc View 1 chunk +45 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/prexmppauth.h View 1 chunk +71 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsub_task.h View 1 chunk +58 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsub_task.cc View 1 chunk +201 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsubclient.h View 1 chunk +111 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsubclient.cc View 1 chunk +129 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsubclient_unittest.cc View 1 chunk +279 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsubstateclient.h View 1 chunk +271 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsubstateclient.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsubtasks.h View 1 chunk +114 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsubtasks.cc View 1 chunk +204 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/pubsubtasks_unittest.cc View 1 chunk +281 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/receivetask.h View 1 chunk +41 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/receivetask.cc View 1 chunk +34 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/rostermodule.h View 1 chunk +331 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/rostermodule_unittest.cc View 1 chunk +832 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/rostermoduleimpl.h View 1 chunk +287 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/rostermoduleimpl.cc View 1 chunk +1064 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/saslcookiemechanism.h View 1 chunk +69 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/saslhandler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/saslmechanism.h View 1 chunk +57 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/saslmechanism.cc View 1 chunk +55 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/saslplainmechanism.h View 1 chunk +48 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/util_unittest.h View 1 chunk +58 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/util_unittest.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppauth.h View 1 chunk +61 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppauth.cc View 1 chunk +88 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppclient.h View 1 chunk +149 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppclient.cc View 1 chunk +423 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppclientsettings.h View 1 chunk +111 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppengine.h View 1 chunk +332 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppengine_unittest.cc View 1 chunk +327 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppengineimpl.h View 1 chunk +267 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppengineimpl.cc View 1 chunk +446 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppengineimpl_iq.cc View 1 chunk +260 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmpplogintask.h View 1 chunk +87 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmpplogintask.cc View 1 chunk +380 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmpplogintask_unittest.cc View 1 chunk +637 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmpppump.h View 1 chunk +62 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmpppump.cc View 1 chunk +67 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppsocket.h View 1 chunk +72 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppsocket.cc View 1 chunk +246 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppstanzaparser.h View 1 chunk +80 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppstanzaparser.cc View 1 chunk +89 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppstanzaparser_unittest.cc View 1 chunk +175 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmpptask.h View 1 chunk +175 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmpptask.cc View 1 chunk +158 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppthread.h View 1 chunk +45 lines, -0 lines 0 comments Download
A webrtc/libjingle/xmpp/xmppthread.cc View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kjellander_webrtc
Created Revert of Remove webrtc/libjingle/{xmllite,xmpp}
3 years, 11 months ago (2017-01-05 06:29:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2618633003/1
3 years, 11 months ago (2017-01-05 06:29:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/60ef117be4b0ebceba94f8fe926f1314fe02721e
3 years, 11 months ago (2017-01-05 06:29:44 UTC) #6
kjellander_webrtc
On 2017/01/05 06:29:44, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-05 07:45:48 UTC) #7
kjellander_webrtc
3 years, 11 months ago (2017-01-05 10:54:42 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2618693002/ by kjellander@webrtc.org.

The reason for reverting is: Last reference to the old code was fixed in
Chromium with https://codereview.chromium.org/2616873002/.

Powered by Google App Engine
This is Rietveld 408576698