Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2612953004: Reland of Fixing package-boundary violation with srjar_deps (Closed)

Created:
3 years, 11 months ago by mbonadei
Modified:
3 years, 11 months ago
Reviewers:
kjellander_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Fixing package-boundary violation with srjar_deps (patchset #1 id:1 of https://codereview.webrtc.org/2617533005/ ) Reason for revert: Skipping the build of the target "//webrtc/modules/audio_device:audio_device_java" when building webrtc with chromium. This was causing a failure because in that case it is not possible to refer to the script used by the template "android_shared_srcjar" with an absolute path (which seems to be necessary since the script attribute of action is relative to the invocation target and not to the template declaration). Original issue's description: > Revert of Fixing package-boundary violation with srjar_deps (patchset #5 id:80001 of https://codereview.webrtc.org/2610823002/ ) > > Reason for revert: > This CL is breaking a chromium.webrtc.fyi: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/226 > > I am trying to reproduce the issue on my local machine and I will try to re-land the CL later. > > Original issue's description: > > Fixing package-boundary violation with srjar_deps > > > > Without the usage of the srcjar_deps attribute we were not able to > > include .java files from other packages without violating the package > > boundary contraint. > > > > As an example, in this CL the target "libjingle_peerconnection_java" was > > directly including .java files from another packages in its "java_files" > > attribute. > > > > Using srcjar_deps we are able to declare the dependency of the target > > avoiding to create hidden dependencies in the codebase. > > > > This is not fixing the webrtc:6356 bug directly but it is a first step to > > include ThreadUtils classes in libjingle_peerconnection_client_java.jar > > again. > > > > It seems also to be related to the chromium:648244 bug. This can be solved > > if we can find a way to perform srcjar generation in the android_library > > target without changing the semantic of the target. > > > > BUG=webrtc:6356 > > > > Review-Url: https://codereview.webrtc.org/2610823002 > > Cr-Commit-Position: refs/heads/master@{#15914} > > Committed: https://chromium.googlesource.com/external/webrtc/+/10a76592a78762187bfaf3547b7e9986454062ab > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6356 > > Review-Url: https://codereview.webrtc.org/2617533005 > Cr-Commit-Position: refs/heads/master@{#15915} > Committed: https://chromium.googlesource.com/external/webrtc/+/eb731ed09ebfea1b26d1b7bc1f2678f7bbc012ee TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6356 Review-Url: https://codereview.webrtc.org/2612953004 Cr-Commit-Position: refs/heads/master@{#15958} Committed: https://chromium.googlesource.com/external/webrtc/+/438062bd436f86b5a41d6b184827ba5ed0d4ee18

Patch Set 1 #

Patch Set 2 : Using rebase_path to make this work in chromium #

Total comments: 2

Patch Set 3 : Skipping audio_device_java in chromium build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -6 lines) Patch
A webrtc/build/generate_srcjar.py View 1 chunk +68 lines, -0 lines 0 comments Download
M webrtc/build/webrtc.gni View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M webrtc/sdk/android/BUILD.gn View 1 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mbonadei
Created Reland of Fixing package-boundary violation with srjar_deps
3 years, 11 months ago (2017-01-05 12:36:40 UTC) #1
kjellander_webrtc
https://codereview.webrtc.org/2612953004/diff/120001/webrtc/build/webrtc.gni File webrtc/build/webrtc.gni (right): https://codereview.webrtc.org/2612953004/diff/120001/webrtc/build/webrtc.gni#newcode343 webrtc/build/webrtc.gni:343: script = rebase_path("//webrtc/build/generate_srcjar.py") I'm wondering if it's safe to ...
3 years, 11 months ago (2017-01-05 19:59:38 UTC) #2
kjellander_webrtc
https://codereview.webrtc.org/2612953004/diff/120001/webrtc/modules/audio_device/BUILD.gn File webrtc/modules/audio_device/BUILD.gn (right): https://codereview.webrtc.org/2612953004/diff/120001/webrtc/modules/audio_device/BUILD.gn#newcode305 webrtc/modules/audio_device/BUILD.gn:305: if (is_android) { make this if (!build_with_chromium && is_android) ...
3 years, 11 months ago (2017-01-05 20:09:16 UTC) #3
mbonadei
This seems all green. I think that I need an lgtm before landing.
3 years, 11 months ago (2017-01-09 09:25:09 UTC) #4
kjellander_webrtc
On 2017/01/09 09:25:09, mbonadei wrote: > This seems all green. I think that I need ...
3 years, 11 months ago (2017-01-09 09:54:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2612953004/140001
3 years, 11 months ago (2017-01-09 10:37:17 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 10:37:24 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/438062bd436f86b5a41d6b184...

Powered by Google App Engine
This is Rietveld 408576698