Revert of Fixing package-boundary violation with srjar_deps

Revert of Fixing package-boundary violation with srjar_deps (patchset #5 id:80001 of https://codereview.webrtc.org/2610823002/ )

Reason for revert:
This CL is breaking a chromium.webrtc.fyi: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/builds/226

I am trying to reproduce the issue on my local machine and I will try to re-land the CL later.

Original issue's description:
> Fixing package-boundary violation with srjar_deps
> 
> Without the usage of the srcjar_deps attribute we were not able to
> include .java files from other packages without violating the package
> boundary contraint.
> 
> As an example, in this CL the target "libjingle_peerconnection_java" was
> directly including .java files from another packages in its "java_files"
> attribute.
> 
> Using srcjar_deps we are able to declare the dependency of the target
> avoiding to create hidden dependencies in the codebase.
> 
> This is not fixing the webrtc:6356 bug directly but it is a first step to
> include ThreadUtils classes in libjingle_peerconnection_client_java.jar
> again.
> 
> It seems also to be related to the chromium:648244 bug. This can be solved
> if we can find a way to perform srcjar generation in the android_library
> target without changing the semantic of the target.
> 
> BUG=webrtc:6356
> 
> Review-Url: https://codereview.webrtc.org/2610823002
> Cr-Commit-Position: refs/heads/master@{#15914}
> Committed: https://chromium.googlesource.com/external/webrtc/+/10a76592a78762187bfaf3547b7e9986454062ab

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6356
Review-Url: https://codereview.webrtc.org/2617533005
Cr-Commit-Position: refs/heads/master@{#15915}
Committed: https://chromium.googlesource.com/external/webrtc/+/eb731ed09ebfea1b26d1b7bc1f2678f7bbc012ee

[mbonadei, 2017-01-05 12:24:21]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-01-05 12:24:21]

Created Revert of Fixing package-boundary violation with srjar_deps

[commit-bot: I haz the power, 2017-01-05 12:24:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-05 12:24:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483619061170530, "parent_rev":
"10a76592a78762187bfaf3547b7e9986454062ab", "commit_rev":
"eb731ed09ebfea1b26d1b7bc1f2678f7bbc012ee"}

[commit-bot: I haz the power, 2017-01-05 12:24:39]

Description was changed from

==========
Revert of Fixing package-boundary violation with srjar_deps (patchset #5
id:80001 of https://codereview.webrtc.org/2610823002/ )

Reason for revert:
This CL is breaking a chromium.webrtc.fyi:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/b...

I am trying to reproduce the issue on my local machine and I will try to re-land
the CL later.

Original issue's description:
> Fixing package-boundary violation with srjar_deps
> 
> Without the usage of the srcjar_deps attribute we were not able to
> include .java files from other packages without violating the package
> boundary contraint.
> 
> As an example, in this CL the target "libjingle_peerconnection_java" was
> directly including .java files from another packages in its "java_files"
> attribute.
> 
> Using srcjar_deps we are able to declare the dependency of the target
> avoiding to create hidden dependencies in the codebase.
> 
> This is not fixing the webrtc:6356 bug directly but it is a first step to
> include ThreadUtils classes in libjingle_peerconnection_client_java.jar
> again.
> 
> It seems also to be related to the chromium:648244 bug. This can be solved
> if we can find a way to perform srcjar generation in the android_library
> target without changing the semantic of the target.
> 
> BUG=webrtc:6356
> 
> Review-Url: https://codereview.webrtc.org/2610823002
> Cr-Commit-Position: refs/heads/master@{#15914}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/10a76592a78762187bfaf3547...

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6356
==========

to

==========
Revert of Fixing package-boundary violation with srjar_deps (patchset #5
id:80001 of https://codereview.webrtc.org/2610823002/ )

Reason for revert:
This CL is breaking a chromium.webrtc.fyi:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder/b...

I am trying to reproduce the issue on my local machine and I will try to re-land
the CL later.

Original issue's description:
> Fixing package-boundary violation with srjar_deps
> 
> Without the usage of the srcjar_deps attribute we were not able to
> include .java files from other packages without violating the package
> boundary contraint.
> 
> As an example, in this CL the target "libjingle_peerconnection_java" was
> directly including .java files from another packages in its "java_files"
> attribute.
> 
> Using srcjar_deps we are able to declare the dependency of the target
> avoiding to create hidden dependencies in the codebase.
> 
> This is not fixing the webrtc:6356 bug directly but it is a first step to
> include ThreadUtils classes in libjingle_peerconnection_client_java.jar
> again.
> 
> It seems also to be related to the chromium:648244 bug. This can be solved
> if we can find a way to perform srcjar generation in the android_library
> target without changing the semantic of the target.
> 
> BUG=webrtc:6356
> 
> Review-Url: https://codereview.webrtc.org/2610823002
> Cr-Commit-Position: refs/heads/master@{#15914}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/10a76592a78762187bfaf3547...

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6356

Review-Url: https://codereview.webrtc.org/2617533005
Cr-Commit-Position: refs/heads/master@{#15915}
Committed:
https://chromium.googlesource.com/external/webrtc/+/eb731ed09ebfea1b26d1b7bc1...
==========

[commit-bot: I haz the power, 2017-01-05 12:24:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/eb731ed09ebfea1b26d1b7bc1...

[mbonadei, 2017-01-05 12:36:39]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2612953004/ by mbonadei@webrtc.org.

The reason for reverting is: Trying to fix the issue and re-land..