Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller for gn check

Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller for gn check.

These targets are now checked:
- "//webrtc/modules/bitrate_controller/*"
- "//webrtc/modules/congestion_controller/*"
- "//webrtc/modules/remote_bitrate_estimator/*"

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2602563003
Cr-Commit-Position: refs/heads/master@{#15818}
Committed: https://chromium.googlesource.com/external/webrtc/+/49f465f4b2eb4c80ac3836129a1b08f7a43665b6

[mbonadei, 2016-12-23 15:10:26]

Description was changed from

==========
Refactor bitrate_controller and congestion_contoller for gn check


Refactor webrtc/modules/remote_bitrate_estimator for gn check


Pacing does not depend on bitrate_controller

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller
for gn check.

These targets are now checked:
- "//webrtc/modules/bitrate_controller/*"
- "//webrtc/modules/congestion_controller/*"
- "//webrtc/modules/remote_bitrate_estimator/*"

BUG=webrtc:6828
NOTRY=True
==========

[mbonadei, 2016-12-23 16:49:26]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[mbonadei, 2016-12-23 16:49:27]

Unfortunately bitrate_controller and remote_birtate_estimator creates a cyclic
dependency with congestion_controller.

[kjellander_webrtc, 2016-12-27 06:22:55]

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/congestion...
File webrtc/modules/congestion_controller/BUILD.gn (right):

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/congestion...
webrtc/modules/congestion_controller/BUILD.gn:50:
"../../system_wrappers:system_wrappers",
GN picks a target named similar to the directory if omitted, so
"../../system_wrappers", is enough here. I don't think the style guide says it's
mandatory, but I think it improves the readability.

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/congestion...
webrtc/modules/congestion_controller/BUILD.gn:53:
"../remote_bitrate_estimator:remote_bitrate_estimator",
same as above; please leave out the implicit target names for increased
readability.

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/remote_bit...
File webrtc/modules/remote_bitrate_estimator/BUILD.gn (right):

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/BUILD.gn:116:
"../../system_wrappers:system_wrappers",
Please leave out explicit target naming here. "../../system_wrappers", will give
you the same, but is easier to read.

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/BUILD.gn:118:
"../../voice_engine:voice_engine",
This is an odd dependency. I think it was introduced with 
https://webrtc-codereview.appspot.com/43299004
Stefan: can you consider doing some refactoring to get rid of it?

[kjellander_webrtc, 2016-12-27 06:23:59]

kjellander@webrtc.org changed reviewers:
+ stefan@webrtc.org

[kjellander_webrtc, 2016-12-27 06:23:59]

+stefan regarding comment in webrtc/modules/remote_bitrate_estimator/BUILD.gn
(forgot to add you when I published them)

[mbonadei, 2016-12-27 14:51:17]

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/congestion...
File webrtc/modules/congestion_controller/BUILD.gn (right):

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/congestion...
webrtc/modules/congestion_controller/BUILD.gn:50:
"../../system_wrappers:system_wrappers",
On 2016/12/27 06:22:54, kjellander_webrtc wrote:
> GN picks a target named similar to the directory if omitted, so
> "../../system_wrappers", is enough here. I don't think the style guide says
it's
> mandatory, but I think it improves the readability.

Acknowledged.

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/congestion...
webrtc/modules/congestion_controller/BUILD.gn:53:
"../remote_bitrate_estimator:remote_bitrate_estimator",
On 2016/12/27 06:22:54, kjellander_webrtc wrote:
> same as above; please leave out the implicit target names for increased
> readability.

Acknowledged.

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/remote_bit...
File webrtc/modules/remote_bitrate_estimator/BUILD.gn (right):

https://codereview.webrtc.org/2602563003/diff/20001/webrtc/modules/remote_bit...
webrtc/modules/remote_bitrate_estimator/BUILD.gn:116:
"../../system_wrappers:system_wrappers",
On 2016/12/27 06:22:55, kjellander_webrtc wrote:
> Please leave out explicit target naming here. "../../system_wrappers", will
give
> you the same, but is easier to read.

Ok, I also removed the explicit target naming from other locations (eg:
"../rtp_rtcp:rtp_rtcp", "../bitrate_controller:bitrate_controller").

[kjellander_webrtc, 2016-12-28 11:57:31]

lgtm

[mbonadei, 2016-12-28 12:41:22]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2016-12-28 12:41:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2602563003/#ps60001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-12-28 12:41:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-28 12:43:46]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482928882015680,
"parent_rev": "7667db4a74ce630c19fff9e0ff953d1990b6301d", "commit_rev":
"49f465f4b2eb4c80ac3836129a1b08f7a43665b6"}

[commit-bot: I haz the power, 2016-12-28 12:43:48]

Description was changed from

==========
Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller
for gn check.

These targets are now checked:
- "//webrtc/modules/bitrate_controller/*"
- "//webrtc/modules/congestion_controller/*"
- "//webrtc/modules/remote_bitrate_estimator/*"

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller
for gn check.

These targets are now checked:
- "//webrtc/modules/bitrate_controller/*"
- "//webrtc/modules/congestion_controller/*"
- "//webrtc/modules/remote_bitrate_estimator/*"

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2602563003
Cr-Commit-Position: refs/heads/master@{#15818}
Committed:
https://chromium.googlesource.com/external/webrtc/+/49f465f4b2eb4c80ac3836129...
==========

[commit-bot: I haz the power, 2016-12-28 12:43:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/49f465f4b2eb4c80ac3836129...