Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller for gn check

webrtc/modules/remote_bitrate_estimator/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../build/webrtc.gni")
 
 rtc_static_library("remote_bitrate_estimator") {
+  # TODO(mbonadei): Remove (bugs.webrtc.org/6828)
+  # Errors on cyclic dependency with:
+  # rtp_rtcp:rtp_rtcp if enabled.
+  check_includes = false
+
   sources = [
     "aimd_rate_control.cc",
     "aimd_rate_control.h",
     "bwe_defines.cc",
     "include/bwe_defines.h",
     "include/remote_bitrate_estimator.h",
     "include/send_time_history.h",
     "inter_arrival.cc",
     "inter_arrival.h",
     "overuse_detector.cc",
@@ skipping 17 matching lines @@
     defines = [ "BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0" ]
   }
 
   if (!build_with_chromium && is_clang) {
     # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
     suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
   }
 
   deps = [
     "../..:webrtc_common",
+    "../../base:rtc_base",
     "../../base:rtc_base_approved",
     "../../system_wrappers",
   ]
 }
 
 if (rtc_include_tests) {
   rtc_static_library("bwe_simulator_lib") {
     testonly = true
     sources = [
       "test/bwe.cc",
@@ skipping 36 matching lines @@
     }
 
     if (is_win) {
       cflags = [
         # TODO(kjellander): Bug 261: fix this warning.
         "/wd4373",  # virtual function override.
       ]
     }
 
     deps = [
+      ":remote_bitrate_estimator",
+      "../..:webrtc_common",
+      "../../base:gtest_prod",
+      "../../base:rtc_base",
+      "../../base:rtc_base_approved",
+      "../../system_wrappers:system_wrappers",

[kjellander_webrtc, 2016/12/27 06:22:55]

Please leave out explicit target naming here. "../../system_wrappers", will give
you the same, but is easier to read.

[mbonadei, 2016/12/27 14:51:17]

Ok, I also removed the explicit target naming from other locations (eg:
"../rtp_rtcp:rtp_rtcp", "../bitrate_controller:bitrate_controller").

       "../../test:test_support",
+      "../../voice_engine:voice_engine",

[kjellander_webrtc, 2016/12/27 06:22:55]

This is an odd dependency. I think it was introduced with 
https://webrtc-codereview.appspot.com/43299004
Stefan: can you consider doing some refactoring to get rid of it?

+      "../bitrate_controller:bitrate_controller",
       "../congestion_controller",
       "../pacing",
+      "../rtp_rtcp:rtp_rtcp",
       "//testing/gmock",
       "//testing/gtest",
     ]
   }
 }