Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2600813002: Revert of Adding error output param to SetConfiguration, using new RTCError type. (Closed)

Created:
3 years, 12 months ago by Taylor Brandstetter
Modified:
3 years, 12 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding error output param to SetConfiguration, using new RTCError type. (patchset #4 id:60001 of https://codereview.webrtc.org/2587133004/ ) Reason for revert: Broke chromium FYI bot because the chromium mock PC overrides the method whose signature is changing. Also broke a downstream internal test, which I need to investigate further. Original issue's description: > Adding error output param to SetConfiguration, using new RTCError type. > > Most notably, will return "INVALID_MODIFICATION" if a field in the > configuration was modified and modification of that field isn't supported. > > Also changing RTCError to a class that wraps an enum type, because it will > eventually need to hold other information (like SDP line number), to match > the RTCError that was recently added to the spec: > https://github.com/w3c/webrtc-pc/pull/850 > > BUG=webrtc:6916 > > Review-Url: https://codereview.webrtc.org/2587133004 > Cr-Commit-Position: refs/heads/master@{#15777} > Committed: https://chromium.googlesource.com/external/webrtc/+/7a5fa6cd6173adbe32aedc1aedc872478121f5ed TBR=pthatcher@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6916 Review-Url: https://codereview.webrtc.org/2600813002 Cr-Commit-Position: refs/heads/master@{#15778} Committed: https://chromium.googlesource.com/external/webrtc/+/1e23461d5ed79b14d918933a0f969603285aad5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -469 lines) Patch
M webrtc/api/peerconnection.h View 3 chunks +8 lines, -16 lines 0 comments Download
M webrtc/api/peerconnection.cc View 17 chunks +66 lines, -193 lines 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 7 chunks +18 lines, -29 lines 0 comments Download
M webrtc/api/peerconnectioninterface.h View 5 chunks +7 lines, -49 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 26 chunks +36 lines, -165 lines 0 comments Download
M webrtc/api/peerconnectionproxy.h View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/media/base/mediachannel.h View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Taylor Brandstetter
Created Revert of Adding error output param to SetConfiguration, using new RTCError type.
3 years, 12 months ago (2016-12-24 09:43:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2600813002/1
3 years, 12 months ago (2016-12-24 09:43:27 UTC) #3
commit-bot: I haz the power
3 years, 12 months ago (2016-12-24 09:43:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/1e23461d5ed79b14d918933a0...

Powered by Google App Engine
This is Rietveld 408576698