Reland of: Adding error output param to SetConfiguration, using new RTCError type.

Reland of: Adding error output param to SetConfiguration, using new RTCError type.

Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.

Also changing RTCError to a class that wraps an enum type, because it will
eventually need to hold other information (like SDP line number), to match
the RTCError that was recently added to the spec:
https://github.com/w3c/webrtc-pc/pull/850

BUG=webrtc:6916
Review-Url: https://codereview.webrtc.org/2587133004
Cr-Original-Commit-Position: refs/heads/master@{#15777}
Committed: https://chromium.googlesource.com/external/webrtc/+/7a5fa6cd6173adbe32aedc1aedc872478121f5ed
Review-Url: https://codereview.webrtc.org/2587133004
Cr-Commit-Position: refs/heads/master@{#16016}
Committed: https://chromium.googlesource.com/external/webrtc/+/293e9263624185d63c8b232182730bac1bd166c3

[Taylor Brandstetter, 2016-12-20 02:04:39]

https://codereview.webrtc.org/2587133004/diff/20001/webrtc/api/peerconnection.cc
File webrtc/api/peerconnection.cc (right):

https://codereview.webrtc.org/2587133004/diff/20001/webrtc/api/peerconnection...
webrtc/api/peerconnection.cc:504: "update operator==?");
This may seem like overkill, but I think there's a high chance of someone
modifying RTCConfiguration and forgetting to update operator== so it seemed
worth it to me. This is only a compile-time thing.

https://codereview.webrtc.org/2587133004/diff/20001/webrtc/api/peerconnection...
webrtc/api/peerconnection.cc:721: return false;
There's no code path in which passing a null PortAllocator works, so I removed
the "if (port_allocator_)" statements and replaced them with this.

https://codereview.webrtc.org/2587133004/diff/20001/webrtc/api/peerconnection...
File webrtc/api/peerconnectioninterface_unittest.cc (right):

https://codereview.webrtc.org/2587133004/diff/20001/webrtc/api/peerconnection...
webrtc/api/peerconnectioninterface_unittest.cc:700: void
CreatePeerConnectionWithoutDtls() {
Added this because I'm constantly confused how I call "CreatePeerConnection" and
end up with a non-DTLS PeerConnection.

[Taylor Brandstetter, 2016-12-20 02:05:58]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2016-12-20 02:05:59]

PTAL Peter. I may replace the enum output parameter with a struct (see email
thread with hta/hbos), but otherwise this CL wouldn't change.

[pthatcher1, 2016-12-21 00:57:24]

lgtm

https://codereview.webrtc.org/2587133004/diff/40001/webrtc/api/peerconnection.cc
File webrtc/api/peerconnection.cc (right):

https://codereview.webrtc.org/2587133004/diff/40001/webrtc/api/peerconnection...
webrtc/api/peerconnection.cc:1399: // support modifying than those we do, and
more could be added.
That's a good approach.  I like it.

[Taylor Brandstetter, 2016-12-21 02:19:58]

Description was changed from

==========
Adding error output param to SetConfiguration, using new RtcError type.

Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.

BUG=webrtc:6916
==========

to

==========
Adding error output param to SetConfiguration, using new RTCError type.

Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.

Also changing RTCError to a class that wraps an enum type, because it will
eventually need to hold other information (like SDP line number), to match
the RTCError that was recently added to the spec:
https://github.com/w3c/webrtc-pc/pull/850

BUG=webrtc:6916
==========

[Taylor Brandstetter, 2016-12-21 02:24:39]

I changed RTCError to a struct instead of an enum, and called the enum
RTCErrorType. Are you good with this? "ErrorType" seems to be a common name for
error enums in assorted chromium code.

[Taylor Brandstetter, 2016-12-22 04:59:12]

ping

[pthatcher1, 2016-12-22 23:49:10]

I'd prefer RtcError over RTCError, but otherwise this seems good.

[pthatcher1, 2016-12-22 23:49:12]

lgtm

I'd prefer RtcError over RTCError, but otherwise this seems good.

[Taylor Brandstetter, 2016-12-24 07:52:50]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-12-24 07:53:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-24 08:48:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482565970693140,
"parent_rev": "edf1cea004d3b401a54f00423118774ccfef9f2d", "commit_rev":
"7a5fa6cd6173adbe32aedc1aedc872478121f5ed"}

[commit-bot: I haz the power, 2016-12-24 08:48:02]

Description was changed from

==========
Adding error output param to SetConfiguration, using new RTCError type.

Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.

Also changing RTCError to a class that wraps an enum type, because it will
eventually need to hold other information (like SDP line number), to match
the RTCError that was recently added to the spec:
https://github.com/w3c/webrtc-pc/pull/850

BUG=webrtc:6916
==========

to

==========
Adding error output param to SetConfiguration, using new RTCError type.

Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.

Also changing RTCError to a class that wraps an enum type, because it will
eventually need to hold other information (like SDP line number), to match
the RTCError that was recently added to the spec:
https://github.com/w3c/webrtc-pc/pull/850

BUG=webrtc:6916

Review-Url: https://codereview.webrtc.org/2587133004
Cr-Commit-Position: refs/heads/master@{#15777}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7a5fa6cd6173adbe32aedc1ae...
==========

[commit-bot: I haz the power, 2016-12-24 08:48:04]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/7a5fa6cd6173adbe32aedc1ae...

[Taylor Brandstetter, 2016-12-24 09:35:54]

This broke the FYI bots but I'm going to fix really quickly, so don't revert.

[Taylor Brandstetter, 2016-12-24 09:43:22]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/2600813002/ by deadbeef@webrtc.org.

The reason for reverting is: Broke chromium FYI bot because the chromium mock PC
overrides the method whose signature is changing.

Also broke a downstream internal test, which I need to investigate further..

[Taylor Brandstetter, 2016-12-24 09:43:43]

Description was changed from

==========
Adding error output param to SetConfiguration, using new RTCError type.

Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.

Also changing RTCError to a class that wraps an enum type, because it will
eventually need to hold other information (like SDP line number), to match
the RTCError that was recently added to the spec:
https://github.com/w3c/webrtc-pc/pull/850

BUG=webrtc:6916

Review-Url: https://codereview.webrtc.org/2587133004
Cr-Commit-Position: refs/heads/master@{#15777}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7a5fa6cd6173adbe32aedc1ae...
==========

to

==========
Reland of: Adding error output param to SetConfiguration, using new RTCError
type.

Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.

Also changing RTCError to a class that wraps an enum type, because it will
eventually need to hold other information (like SDP line number), to match
the RTCError that was recently added to the spec:
https://github.com/w3c/webrtc-pc/pull/850

BUG=webrtc:6916

Review-Url: https://codereview.webrtc.org/2587133004
Cr-Commit-Position: refs/heads/master@{#15777}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7a5fa6cd6173adbe32aedc1ae...
==========

[Taylor Brandstetter, 2017-01-10 17:40:28]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-10 17:40:28]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2587133004/#ps100001 (title:
"Rebasing")

[commit-bot: I haz the power, 2017-01-10 17:40:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-10 17:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 17:47:26]

Try jobs failed on following builders:
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[Taylor Brandstetter, 2017-01-10 19:52:04]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-10 19:52:04]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2587133004/#ps120001 (title:
"Fixing compile warning.")

[commit-bot: I haz the power, 2017-01-10 19:52:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-10 19:59:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 19:59:23]

Try jobs failed on following builders:
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/20101)
  android_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/19941)

[Taylor Brandstetter, 2017-01-11 19:40:50]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-11 19:40:53]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2587133004/#ps180001 (title:
"Fixing compile error in less confusing way.")

[commit-bot: I haz the power, 2017-01-11 19:40:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-11 20:28:31]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1484163650553160,
"parent_rev": "a4eb29842c676a085d27866f79dff1c8998cc0d0", "commit_rev":
"293e9263624185d63c8b232182730bac1bd166c3"}

[commit-bot: I haz the power, 2017-01-11 20:28:35]

Description was changed from

==========
Reland of: Adding error output param to SetConfiguration, using new RTCError
type.

Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.

Also changing RTCError to a class that wraps an enum type, because it will
eventually need to hold other information (like SDP line number), to match
the RTCError that was recently added to the spec:
https://github.com/w3c/webrtc-pc/pull/850

BUG=webrtc:6916

Review-Url: https://codereview.webrtc.org/2587133004
Cr-Commit-Position: refs/heads/master@{#15777}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7a5fa6cd6173adbe32aedc1ae...
==========

to

==========
Reland of: Adding error output param to SetConfiguration, using new RTCError
type.

Most notably, will return "INVALID_MODIFICATION" if a field in the
configuration was modified and modification of that field isn't supported.

Also changing RTCError to a class that wraps an enum type, because it will
eventually need to hold other information (like SDP line number), to match
the RTCError that was recently added to the spec:
https://github.com/w3c/webrtc-pc/pull/850

BUG=webrtc:6916

Review-Url: https://codereview.webrtc.org/2587133004
Cr-Original-Commit-Position: refs/heads/master@{#15777}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7a5fa6cd6173adbe32aedc1ae...
Review-Url: https://codereview.webrtc.org/2587133004
Cr-Commit-Position: refs/heads/master@{#16016}
Committed:
https://chromium.googlesource.com/external/webrtc/+/293e9263624185d63c8b23218...
==========

[commit-bot: I haz the power, 2017-01-11 20:28:36]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/293e9263624185d63c8b23218...