Reland "Refactor webrtc/modules/video_processing for GN check"

Reland "Refactor webrtc/modules/video_processing for GN check"

This reverts commit d39e16ac300d7947d22b953898aaef073e553ad3.

This will fix the missing dependency which was causing the failure of many
buildbots.

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2597643002
Cr-Commit-Position: refs/heads/master@{#15805}
Committed: https://chromium.googlesource.com/external/webrtc/+/6d3c57300b8399355e054565f285719e888bd452

[mbonadei, 2016-12-21 12:43:37]

Reverting the revert and fixing the problem.

Yesterday I forgot to refactor :video_processing_neon and this was causing the
following error on some buildbots:

ERROR at //webrtc/modules/video_processing/util/denoiser_filter_neon.h:14:11:
Include not allowed.
#include "webrtc/modules/video_processing/util/denoiser_filter.h"
          ^-----------------------------------------------------
It is not in any dependency of
  //webrtc/modules/video_processing:video_processing_neon
The include file is in the target(s):
  //webrtc/modules/video_processing:video_processing
which should somehow be reachable.

Like :video_processing_sse2 there is a cyclic dependency on :video_processing so
I skipped the check and added a TODO.

[mbonadei, 2016-12-21 12:52:19]

Description was changed from

==========
Revert "Revert of Refactor webrtc/modules/video_processing for GN check
(patchset #3 id:40001 of https://codereview.webrtc.org/2595543002/ )"

This reverts commit d39e16ac300d7947d22b953898aaef073e553ad3.

This will fix the missing dependency which was causing the failure of many
buildbots.

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Revert "Revert of Refactor webrtc/modules/video_processing for GN check
(patchset #3 id:40001 of https://codereview.webrtc.org/2595543002/ )"

This reverts commit d39e16ac300d7947d22b953898aaef073e553ad3.

This will fix the missing dependency which was causing the failure of many
buildbots.

BUG=webrtc:6828
NOTRY=True
==========

[mbonadei, 2016-12-21 12:52:19]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[mbonadei, 2016-12-23 08:09:46]

On 2016/12/21 12:43:37, mbonadei wrote:
> Reverting the revert and fixing the problem.
> 
> Yesterday I forgot to refactor :video_processing_neon and this was causing the
> following error on some buildbots:
> 
> ERROR at //webrtc/modules/video_processing/util/denoiser_filter_neon.h:14:11:
> Include not allowed.
> #include "webrtc/modules/video_processing/util/denoiser_filter.h"
>           ^-----------------------------------------------------
> It is not in any dependency of
>   //webrtc/modules/video_processing:video_processing_neon
> The include file is in the target(s):
>   //webrtc/modules/video_processing:video_processing
> which should somehow be reachable.
> 
> Like :video_processing_sse2 there is a cyclic dependency on :video_processing
so
> I skipped the check and added a TODO.

Ok, the problem which caused the breakage is now fixed. We are also green on
both webrtc-trybots and chromium-trybots.
Ready for the final review.

[kjellander_webrtc, 2016-12-27 06:09:20]

Description was changed from

==========
Revert "Revert of Refactor webrtc/modules/video_processing for GN check
(patchset #3 id:40001 of https://codereview.webrtc.org/2595543002/ )"

This reverts commit d39e16ac300d7947d22b953898aaef073e553ad3.

This will fix the missing dependency which was causing the failure of many
buildbots.

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Reland "Refactor webrtc/modules/video_processing for GN check"

This reverts commit d39e16ac300d7947d22b953898aaef073e553ad3.

This will fix the missing dependency which was causing the failure of many
buildbots.

BUG=webrtc:6828
NOTRY=True
==========

[kjellander_webrtc, 2016-12-27 06:14:13]

lgtm. I rephrased the title to say "Reland" instead of double-revert. That's
also how the message becomes when you revert a revert-CL in the code review tool
(but git revert on the command line will give you the double-revert message).

I usually do like this when I want to reland a CL that requires additional
modifications:
1. revert via web ui, uncheck the CQ checkbox
2. Note the CL number in the URL of the generated new CL
3. Patch a local branch with that CL: git cl patch <number>
4. Do the necessary local changes on the branch for relanding it
5. git cl upload and name the new patch set accordingly to make it easy for the
reviewer. That way it's easy for the reviewer to see the difference between the
pristine revert-CL and the additional changes.

You pretty much did the same thing here, which is nice. I guess you just used
git revert locally though.

[mbonadei, 2016-12-27 14:30:00]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2016-12-27 14:30:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2597643002/#ps80001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-12-27 14:30:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-27 14:32:09]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1482849000170040,
"parent_rev": "d5b6d7a7b9c4ac9ca668d5f94265153cec7b0f0f", "commit_rev":
"6d3c57300b8399355e054565f285719e888bd452"}

[commit-bot: I haz the power, 2016-12-27 14:32:11]

Description was changed from

==========
Reland "Refactor webrtc/modules/video_processing for GN check"

This reverts commit d39e16ac300d7947d22b953898aaef073e553ad3.

This will fix the missing dependency which was causing the failure of many
buildbots.

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Reland "Refactor webrtc/modules/video_processing for GN check"

This reverts commit d39e16ac300d7947d22b953898aaef073e553ad3.

This will fix the missing dependency which was causing the failure of many
buildbots.

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2597643002
Cr-Commit-Position: refs/heads/master@{#15805}
Committed:
https://chromium.googlesource.com/external/webrtc/+/6d3c57300b8399355e054565f...
==========

[commit-bot: I haz the power, 2016-12-27 14:32:12]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/6d3c57300b8399355e054565f...