Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Unified Diff: webrtc/modules/video_processing/BUILD.gn

Issue 2597643002: Reland "Refactor webrtc/modules/video_processing for GN check" (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_processing/BUILD.gn
diff --git a/webrtc/modules/video_processing/BUILD.gn b/webrtc/modules/video_processing/BUILD.gn
index b1ab8ecc5e38f638af207f74bb4b2aee33478c01..5ab3f457ecdc108398d3b2b29809b551bbf54ed6 100644
--- a/webrtc/modules/video_processing/BUILD.gn
+++ b/webrtc/modules/video_processing/BUILD.gn
@@ -26,6 +26,7 @@ rtc_static_library("video_processing") {
]
deps = [
+ "../../base:rtc_base_approved",
"../../common_audio",
"../../common_video",
"../../modules/utility",
@@ -46,11 +47,20 @@ rtc_static_library("video_processing") {
if (build_video_processing_sse2) {
rtc_static_library("video_processing_sse2") {
+ # TODO(mbonadei): Remove (bugs.webrtc.org/6828)
+ # Errors on cyclic dependency with :video_processing if enabled.
+ check_includes = false
+
sources = [
"util/denoiser_filter_sse2.cc",
"util/denoiser_filter_sse2.h",
]
+ deps = [
+ "../../base:rtc_base_approved",
+ "../../system_wrappers",
+ ]
+
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
@@ -64,10 +74,15 @@ if (build_video_processing_sse2) {
if (rtc_build_with_neon) {
rtc_static_library("video_processing_neon") {
+ # TODO(mbonadei): Remove (bugs.webrtc.org/6828)
+ # Errors on cyclic dependency with :video_processing if enabled.
+ check_includes = false
+
sources = [
"util/denoiser_filter_neon.cc",
"util/denoiser_filter_neon.h",
]
+
if (current_cpu != "arm64") {
suppressed_configs += [ "//build/config/compiler:compiler_arm_fpu" ]
cflags = [ "-mfpu=neon" ]
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698