Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2591963003: RTCIceCandidateStats.deleted = false added. (Closed)

Created:
3 years, 12 months ago by hbos
Modified:
3 years, 11 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCIceCandidateStats.deleted = false added. Since previously, only the deleted = false case is supported, but now that stat is added. It's a recent addition to the spec: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted BUG=webrtc:6756, chromium:632723, chromium:627816 Review-Url: https://codereview.webrtc.org/2591963003 Cr-Commit-Position: refs/heads/master@{#15871} Committed: https://chromium.googlesource.com/external/webrtc/+/d17a5a7709fcef98bb6fcd0d2a99e11dfcc38bb7

Patch Set 1 #

Patch Set 2 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M webrtc/api/rtcstats_integrationtest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 1 7 chunks +7 lines, -0 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
hbos
Please take a look, hta.
3 years, 12 months ago (2016-12-21 15:41:26 UTC) #4
hta-webrtc
lgtm
3 years, 11 months ago (2017-01-02 13:50:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2591963003/20001
3 years, 11 months ago (2017-01-02 15:01:50 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 16:10:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/d17a5a7709fcef98bb6fcd0d2...

Powered by Google App Engine
This is Rietveld 408576698