Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: webrtc/api/stats/rtcstats_objects.h

Issue 2591963003: RTCIceCandidateStats.deleted = false added. (Closed)
Patch Set: Rebase with master Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/rtcstatscollector_unittest.cc ('k') | webrtc/stats/rtcstats_objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 172
173 RTCStatsMember<bool> is_remote; 173 RTCStatsMember<bool> is_remote;
174 RTCStatsMember<std::string> ip; 174 RTCStatsMember<std::string> ip;
175 RTCStatsMember<int32_t> port; 175 RTCStatsMember<int32_t> port;
176 RTCStatsMember<std::string> protocol; 176 RTCStatsMember<std::string> protocol;
177 // TODO(hbos): Support enum types? "RTCStatsMember<RTCIceCandidateType>"? 177 // TODO(hbos): Support enum types? "RTCStatsMember<RTCIceCandidateType>"?
178 RTCStatsMember<std::string> candidate_type; 178 RTCStatsMember<std::string> candidate_type;
179 RTCStatsMember<int32_t> priority; 179 RTCStatsMember<int32_t> priority;
180 // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/632723 180 // TODO(hbos): Not collected by |RTCStatsCollector|. crbug.com/632723
181 RTCStatsMember<std::string> url; 181 RTCStatsMember<std::string> url;
182 // TODO(hbos): |deleted = true| case is not supported by |RTCStatsCollector|.
183 // crbug.com/632723
184 RTCStatsMember<bool> deleted; // = false
182 185
183 protected: 186 protected:
184 RTCIceCandidateStats( 187 RTCIceCandidateStats(
185 const std::string& id, int64_t timestamp_us, bool is_remote); 188 const std::string& id, int64_t timestamp_us, bool is_remote);
186 RTCIceCandidateStats(std::string&& id, int64_t timestamp_us, bool is_remote); 189 RTCIceCandidateStats(std::string&& id, int64_t timestamp_us, bool is_remote);
187 }; 190 };
188 191
189 // In the spec both local and remote varieties are of type RTCIceCandidateStats. 192 // In the spec both local and remote varieties are of type RTCIceCandidateStats.
190 // But here we define them as subclasses of |RTCIceCandidateStats| because the 193 // But here we define them as subclasses of |RTCIceCandidateStats| because the
191 // |kType| need to be different ("RTCStatsType type") in the local/remote case. 194 // |kType| need to be different ("RTCStatsType type") in the local/remote case.
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 RTCStatsMember<std::string> rtcp_transport_stats_id; 393 RTCStatsMember<std::string> rtcp_transport_stats_id;
391 RTCStatsMember<bool> active_connection; 394 RTCStatsMember<bool> active_connection;
392 RTCStatsMember<std::string> selected_candidate_pair_id; 395 RTCStatsMember<std::string> selected_candidate_pair_id;
393 RTCStatsMember<std::string> local_certificate_id; 396 RTCStatsMember<std::string> local_certificate_id;
394 RTCStatsMember<std::string> remote_certificate_id; 397 RTCStatsMember<std::string> remote_certificate_id;
395 }; 398 };
396 399
397 } // namespace webrtc 400 } // namespace webrtc
398 401
399 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_ 402 #endif // WEBRTC_API_STATS_RTCSTATS_OBJECTS_H_
OLDNEW
« no previous file with comments | « webrtc/api/rtcstatscollector_unittest.cc ('k') | webrtc/stats/rtcstats_objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698