Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2589703002: Revert of Re-enable Opus complexity tests on Android (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, danilchap
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Re-enable Opus complexity tests on Android (patchset #1 id:1 of https://codereview.webrtc.org/2589673002/ ) Reason for revert: This fails on perf bots. See for instance https://uberchromegw.corp.google.com/i/client.webrtc.perf/builders/Android32%20Tests%20%28K%20Nexus5%29/builds/105/steps/webrtc_perf_tests/logs/stdio: I 643.319s run_tests_on_device(03832b22f0e944a0) Note: Google Test filter = AudioEncoderOpusComplexityAdaptationTest.AdaptationOff I 643.319s run_tests_on_device(03832b22f0e944a0) [==========] Running 1 test from 1 test case. I 643.319s run_tests_on_device(03832b22f0e944a0) [----------] Global test environment set-up. I 643.319s run_tests_on_device(03832b22f0e944a0) [----------] 1 test from AudioEncoderOpusComplexityAdaptationTest I 643.319s run_tests_on_device(03832b22f0e944a0) [ RUN ] AudioEncoderOpusComplexityAdaptationTest.AdaptationOff I 643.319s run_tests_on_device(03832b22f0e944a0) ../../webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:36: Failure I 643.319s run_tests_on_device(03832b22f0e944a0) Value of: audio_loop.Init(kInputFileName, kMaxLoopLengthSamples, kInputBlockSizeSamples) I 643.320s run_tests_on_device(03832b22f0e944a0) Actual: false I 643.320s run_tests_on_device(03832b22f0e944a0) Expected: true I 643.320s run_tests_on_device(03832b22f0e944a0) [ CRASHED ] I 643.405s run_tests_on_device(0384888cf0e945d1) >>ScopedMainEntryLogger I 643.405s run_tests_on_device(0384888cf0e945d1) Note: Google Test filter = AudioEncoderOpusComplexityAdaptationTest.AdaptationOn I 643.405s run_tests_on_device(0384888cf0e945d1) [==========] Running 1 test from 1 test case. I 643.405s run_tests_on_device(0384888cf0e945d1) [----------] Global test environment set-up. I 643.405s run_tests_on_device(0384888cf0e945d1) [----------] 1 test from AudioEncoderOpusComplexityAdaptationTest I 643.405s run_tests_on_device(0384888cf0e945d1) [ RUN ] AudioEncoderOpusComplexityAdaptationTest.AdaptationOn I 643.405s run_tests_on_device(0384888cf0e945d1) ../../webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:36: Failure I 643.405s run_tests_on_device(0384888cf0e945d1) Value of: audio_loop.Init(kInputFileName, kMaxLoopLengthSamples, kInputBlockSizeSamples) I 643.405s run_tests_on_device(0384888cf0e945d1) Actual: false I 643.405s run_tests_on_device(0384888cf0e945d1) Expected: true I 643.405s run_tests_on_device(0384888cf0e945d1) [ CRASHED ] Original issue's description: > Re-enable Opus complexity tests on Android > > BUG=webrtc:6708 > TBR=minyue@webrtc.org > > Review-Url: https://codereview.webrtc.org/2589673002 > Cr-Commit-Position: refs/heads/master@{#15667} > Committed: https://chromium.googlesource.com/external/webrtc/+/14479ddfd49f64e2a996d363220ab268dfb20c6e TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6708 Review-Url: https://codereview.webrtc.org/2589703002 Cr-Commit-Position: refs/heads/master@{#15668} Committed: https://chromium.googlesource.com/external/webrtc/+/c3e1cabc696240e4b5a128653264785292878205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hlundin-webrtc
Created Revert of Re-enable Opus complexity tests on Android
4 years ago (2016-12-19 10:03:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2589703002/1
4 years ago (2016-12-19 10:03:26 UTC) #3
commit-bot: I haz the power
4 years ago (2016-12-19 10:03:36 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/c3e1cabc696240e4b5a128653...

Powered by Google App Engine
This is Rietveld 408576698