Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2589673002: Re-enable Opus complexity tests on Android (Closed)

Created:
4 years ago by hlundin-webrtc
Modified:
4 years ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, danilchap
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-enable Opus complexity tests on Android BUG=webrtc:6708 TBR=minyue@webrtc.org Review-Url: https://codereview.webrtc.org/2589673002 Cr-Commit-Position: refs/heads/master@{#15667} Committed: https://chromium.googlesource.com/external/webrtc/+/14479ddfd49f64e2a996d363220ab268dfb20c6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hlundin-webrtc
This is an exploratory CL. Last time this test was enabled it broke on Android, ...
4 years ago (2016-12-19 09:09:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2589673002/1
4 years ago (2016-12-19 09:09:28 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/14479ddfd49f64e2a996d363220ab268dfb20c6e
4 years ago (2016-12-19 09:36:38 UTC) #7
hlundin-webrtc
4 years ago (2016-12-19 10:03:16 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2589703002/ by henrik.lundin@webrtc.org.

The reason for reverting is: This fails on perf bots.

See for instance
https://uberchromegw.corp.google.com/i/client.webrtc.perf/builders/Android32%...:

I  643.319s run_tests_on_device(03832b22f0e944a0)  Note: Google Test filter =
AudioEncoderOpusComplexityAdaptationTest.AdaptationOff
I  643.319s run_tests_on_device(03832b22f0e944a0)  [==========] Running 1 test
from 1 test case.
I  643.319s run_tests_on_device(03832b22f0e944a0)  [----------] Global test
environment set-up.
I  643.319s run_tests_on_device(03832b22f0e944a0)  [----------] 1 test from
AudioEncoderOpusComplexityAdaptationTest
I  643.319s run_tests_on_device(03832b22f0e944a0)  [ RUN      ]
AudioEncoderOpusComplexityAdaptationTest.AdaptationOff
I  643.319s run_tests_on_device(03832b22f0e944a0) 
../../webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:36:
Failure
I  643.319s run_tests_on_device(03832b22f0e944a0)  Value of:
audio_loop.Init(kInputFileName, kMaxLoopLengthSamples, kInputBlockSizeSamples)
I  643.320s run_tests_on_device(03832b22f0e944a0)    Actual: false
I  643.320s run_tests_on_device(03832b22f0e944a0)  Expected: true
I  643.320s run_tests_on_device(03832b22f0e944a0)  [ CRASHED      ]
I  643.405s run_tests_on_device(0384888cf0e945d1)  >>ScopedMainEntryLogger
I  643.405s run_tests_on_device(0384888cf0e945d1)  Note: Google Test filter =
AudioEncoderOpusComplexityAdaptationTest.AdaptationOn
I  643.405s run_tests_on_device(0384888cf0e945d1)  [==========] Running 1 test
from 1 test case.
I  643.405s run_tests_on_device(0384888cf0e945d1)  [----------] Global test
environment set-up.
I  643.405s run_tests_on_device(0384888cf0e945d1)  [----------] 1 test from
AudioEncoderOpusComplexityAdaptationTest
I  643.405s run_tests_on_device(0384888cf0e945d1)  [ RUN      ]
AudioEncoderOpusComplexityAdaptationTest.AdaptationOn
I  643.405s run_tests_on_device(0384888cf0e945d1) 
../../webrtc/modules/audio_coding/codecs/opus/opus_complexity_unittest.cc:36:
Failure
I  643.405s run_tests_on_device(0384888cf0e945d1)  Value of:
audio_loop.Init(kInputFileName, kMaxLoopLengthSamples, kInputBlockSizeSamples)
I  643.405s run_tests_on_device(0384888cf0e945d1)    Actual: false
I  643.405s run_tests_on_device(0384888cf0e945d1)  Expected: true
I  643.405s run_tests_on_device(0384888cf0e945d1)  [ CRASHED      ]
.

Powered by Google App Engine
This is Rietveld 408576698