Fixing relative paths and adding a docstring

Fixing relative paths and adding a docstring

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2589223002
Cr-Commit-Position: refs/heads/master@{#15714}
Committed: https://chromium.googlesource.com/external/webrtc/+/235d5cca4a4258e18fa58df55d2738be0bf9095e

[mbonadei, 2016-12-20 12:38:42]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[mbonadei, 2016-12-20 12:38:42]

mbonadei@webrtc.org changed required reviewers:
+ kjellander@webrtc.org

[mbonadei, 2016-12-20 12:38:43]

This CL fixes the script and adds a small docstring.

[kjellander_webrtc, 2016-12-20 13:30:42]

Description was changed from

==========
Fixing relative paths and adding a docstring

BUG=webrtc:6828
==========

to

==========
Fixing relative paths and adding a docstring

BUG=webrtc:6828
NOTRY=True
==========

[kjellander_webrtc, 2016-12-20 13:30:42]

kjellander@webrtc.org changed required reviewers:
- kjellander@webrtc.org

[kjellander_webrtc, 2016-12-20 13:35:55]

lgtm with one possible further improvement mentioned in my comments

I added NOTRY=True to the description of this CL, since it doesn't affect
anything that runs on the bots. That way, we won't trigger 30 tryjobs when
putting this into the CQ (by checking the Commit checkbox). You could also land
this manually by using 'git cl land' to skip the CQ entirely, but normally it's
preferred to always use it (and it's not the end of the world if one commits
simple CLs like this and forgets about NOTRY=True).

https://codereview.webrtc.org/2589223002/diff/1/tools-webrtc/gn_check_autofix.py
File tools-webrtc/gn_check_autofix.py (right):

https://codereview.webrtc.org/2589223002/diff/1/tools-webrtc/gn_check_autofix...
tools-webrtc/gn_check_autofix.py:112: 'tools-webrtc/mb/mb.py', 'gen',
I'm a bit curious how this works. Does the script only work when being run from
the src/ directory as current working directory? 

Not that we have to fix that, but usually I use something like SCRIPT_DIR:
https://cs.chromium.org/chromium/src/third_party/webrtc/tools/compare_videos....
then I do os.path.join(SCRIPT_DIR...
to get absolute paths.

[mbonadei, 2016-12-20 13:47:38]

https://codereview.webrtc.org/2589223002/diff/1/tools-webrtc/gn_check_autofix.py
File tools-webrtc/gn_check_autofix.py (right):

https://codereview.webrtc.org/2589223002/diff/1/tools-webrtc/gn_check_autofix...
tools-webrtc/gn_check_autofix.py:112: 'tools-webrtc/mb/mb.py', 'gen',
On 2016/12/20 13:35:55, kjellander_webrtc wrote:
> I'm a bit curious how this works. Does the script only work when being run
from
> the src/ directory as current working directory? 
> 
> Not that we have to fix that, but usually I use something like SCRIPT_DIR:
>
https://cs.chromium.org/chromium/src/third_party/webrtc/tools/compare_videos....
> then I do os.path.join(SCRIPT_DIR...
> to get absolute paths.

Yep, it works only if it is run from `src`. I agree that this should be
documented or fixed. Let me fix it.

[mbonadei, 2016-12-20 15:16:32]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2016-12-20 15:16:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2589223002/#ps20001 (title:
"Removing dependency from `src` as current working directory")

[commit-bot: I haz the power, 2016-12-20 15:16:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-20 15:19:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482246992378920,
"parent_rev": "4f6296fa6512af008b12cbbc3d19c6d2b60ab70d", "commit_rev":
"235d5cca4a4258e18fa58df55d2738be0bf9095e"}

[commit-bot: I haz the power, 2016-12-20 15:19:20]

Description was changed from

==========
Fixing relative paths and adding a docstring

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Fixing relative paths and adding a docstring

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2589223002
Cr-Commit-Position: refs/heads/master@{#15714}
Committed:
https://chromium.googlesource.com/external/webrtc/+/235d5cca4a4258e18fa58df55...
==========

[commit-bot: I haz the power, 2016-12-20 15:19:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/235d5cca4a4258e18fa58df55...