Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: tools-webrtc/gn_check_autofix.py

Issue 2589223002: Fixing relative paths and adding a docstring (Closed)
Patch Set: Removing dependency from `src` as current working directory Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools-webrtc/gn_check_autofix.py
diff --git a/tools-webrtc/gn_check_autofix.py b/tools-webrtc/gn_check_autofix.py
index 54ca1b0418621dce102bf9fa572dd87831dc6b75..8a79cdec259817818451155334c716698708cda2 100644
--- a/tools-webrtc/gn_check_autofix.py
+++ b/tools-webrtc/gn_check_autofix.py
@@ -8,6 +8,18 @@
# in the file PATENTS. All contributing project authors may
# be found in the AUTHORS file in the root of the source tree.
+"""
+This tool tries to fix (some) errors reported by `gn gen --check` or
+`gn check`.
+It will run `mb gen` in a temporary directory and it is really useful to
+check for different configurations.
+
+Usage:
+ $ python tools-webrtc/gn_check_autofix.py -m some_mater -b some_bot
+ or
+ $ python tools-webrtc/gn_check_autofix.py -c some_mb_config
+"""
+
import os
import re
import shutil
@@ -17,6 +29,8 @@ import tempfile
from collections import defaultdict
+SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
+
TARGET_RE = re.compile(
r'(?P<indentation_level>\s*)\w*\("(?P<target_name>\w*)"\) {$')
@@ -96,10 +110,12 @@ def main():
errors_by_file = defaultdict(lambda: defaultdict(set))
with TemporaryDirectory() as tmp_dir:
+ mb_script_path = os.path.join(SCRIPT_DIR, 'mb', 'mb.py')
+ mb_config_file_path = os.path.join(SCRIPT_DIR, 'mb', 'mb_config.pyl')
mb_gen_command = ([
- 'tools/mb/mb.py', 'gen',
+ mb_script_path, 'gen',
tmp_dir,
- '--config-file', 'webrtc/build/mb_config.pyl',
+ '--config-file', mb_config_file_path,
] + sys.argv[1:])
mb_output = Run(mb_gen_command)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698