Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2585703002:
Add full stack tests (ForemanCif30kbpsWithoutPacketLoss, ForemanCif30kbpsWithoutPacketLossH264) (Closed)
|
Created:
4 years ago by åsapersson Modified:
4 years ago CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd full stack tests:
- ForemanCif30kbpsWithoutPacketLoss
- ForemanCif30kbpsWithoutPacketLossH264
BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/2585703002
Cr-Commit-Position: refs/heads/master@{#15658}
Committed: https://chromium.googlesource.com/external/webrtc/+/fb6ad3b1961bde202b3102f8006acd2ce373acd4
Patch Set 1 #
Total comments: 4
Patch Set 2 : address comments #Messages
Total messages: 29 (19 generated)
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Add full stack tests: - ForemanCif30kbpsWithoutPacketLoss - ForemanCif30kbpsWithoutPacketLossH264 BUG=webrtc:6634 ========== to ========== Add full stack tests: - ForemanCif30kbpsWithoutPacketLoss - ForemanCif30kbpsWithoutPacketLossH264 BUG=webrtc:6634 ==========
asapersson@webrtc.org changed reviewers: + brandtr@webrtc.org, mflodman@webrtc.org
lgtm You might want to expand the first line of the commit message, to make it more understandable in the git log.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Minor comments, then lgtm. https://codereview.webrtc.org/2585703002/diff/1/webrtc/video/full_stack_tests.cc File webrtc/video/full_stack_tests.cc (right): https://codereview.webrtc.org/2585703002/diff/1/webrtc/video/full_stack_tests... webrtc/video/full_stack_tests.cc:86: "VP8", 1, 0, 0, false, false, "", "foreman_cif"}; Can you remove the extra empty spaces. https://codereview.webrtc.org/2585703002/diff/1/webrtc/video/full_stack_tests... webrtc/video/full_stack_tests.cc:143: foreman_cif.video = {true, 352, 288, 10, 30000, 30000, 30000, And here too.
https://codereview.webrtc.org/2585703002/diff/1/webrtc/video/full_stack_tests.cc File webrtc/video/full_stack_tests.cc (right): https://codereview.webrtc.org/2585703002/diff/1/webrtc/video/full_stack_tests... webrtc/video/full_stack_tests.cc:86: "VP8", 1, 0, 0, false, false, "", "foreman_cif"}; On 2016/12/16 11:04:14, mflodman wrote: > Can you remove the extra empty spaces. Done (from git cl format) https://codereview.webrtc.org/2585703002/diff/1/webrtc/video/full_stack_tests... webrtc/video/full_stack_tests.cc:143: foreman_cif.video = {true, 352, 288, 10, 30000, 30000, 30000, On 2016/12/16 11:04:14, mflodman wrote: > And here too. Done.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by asapersson@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org, mflodman@webrtc.org Link to the patchset: https://codereview.webrtc.org/2585703002/#ps40001 (title: "address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
The CQ bit was checked by asapersson@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_dbg/builds/14587)
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481898766244380,
"parent_rev": "5bf9bedaa12af97698f0225c1c2c86de3697aa15", "commit_rev":
"fb6ad3b1961bde202b3102f8006acd2ce373acd4"}
Message was sent while issue was closed.
Description was changed from ========== Add full stack tests: - ForemanCif30kbpsWithoutPacketLoss - ForemanCif30kbpsWithoutPacketLossH264 BUG=webrtc:6634 ========== to ========== Add full stack tests: - ForemanCif30kbpsWithoutPacketLoss - ForemanCif30kbpsWithoutPacketLossH264 BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2585703002 Cr-Commit-Position: refs/heads/master@{#15658} Committed: https://chromium.googlesource.com/external/webrtc/+/fb6ad3b1961bde202b3102f80... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/fb6ad3b1961bde202b3102f80... |
