Add full stack tests (ForemanCif30kbpsWithoutPacketLoss, ForemanCif30kbpsWithoutPacketLossH264)

webrtc/video/full_stack_tests.cc

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #include <stdio.h>
@@ skipping 61 matching lines @@
   // TODO(pbos): Decide on psnr/ssim thresholds for foreman_cif.
   VideoQualityTest::Params foreman_cif;
   foreman_cif.call.send_side_bwe = true;
   foreman_cif.video = {true, 352, 288, 30, 700000, 700000, 700000, false, "VP8",
                        1, 0, 0, false, false, "", "foreman_cif"};
   foreman_cif.analyzer = {"foreman_cif_net_delay_0_0_plr_0", 0.0, 0.0,
                           kFullStackTestDurationSecs};
   RunTest(foreman_cif);
 }
 
+TEST_F(FullStackTest, ForemanCif30kbpsWithoutPacketLoss) {
+  VideoQualityTest::Params foreman_cif;
+  foreman_cif.call.send_side_bwe = true;
+  foreman_cif.video = {true,  352, 288, 10, 30000, 30000, 30000, false,
+                       "VP8", 1,   0,   0,  false, false, "",    "foreman_cif"};

[mflodman, 2016/12/16 11:04:14]

Can you remove the extra empty spaces.

[åsapersson, 2016/12/16 11:21:58]

Done (from git cl format)

+  foreman_cif.analyzer = {"foreman_cif_30kbps_net_delay_0_0_plr_0", 0.0, 0.0,
+                          kFullStackTestDurationSecs};
+  RunTest(foreman_cif);
+}
+
 TEST_F(FullStackTest, ForemanCifPlr5) {
   VideoQualityTest::Params foreman_cif;
   foreman_cif.call.send_side_bwe = true;
   foreman_cif.video = {true, 352, 288, 30, 30000, 500000, 2000000, false, "VP8",
                        1, 0, 0, false, false, "", "foreman_cif"};
   foreman_cif.analyzer = {"foreman_cif_delay_50_0_plr_5", 0.0, 0.0,
                           kFullStackTestDurationSecs};
   foreman_cif.pipe.loss_percent = 5;
   foreman_cif.pipe.queue_delay_ms = 50;
   RunTest(foreman_cif);
@@ skipping 28 matching lines @@
   // TODO(pbos): Decide on psnr/ssim thresholds for foreman_cif.
   VideoQualityTest::Params foreman_cif;
   foreman_cif.call.send_side_bwe = true;
   foreman_cif.video = {true, 352, 288, 30, 700000, 700000, 700000, false,
                        "H264", 1, 0, 0, false, false, "", "foreman_cif"};
   foreman_cif.analyzer = {"foreman_cif_net_delay_0_0_plr_0_H264", 0.0, 0.0,
                           kFullStackTestDurationSecs};
   RunTest(foreman_cif);
 }
 
+TEST_F(FullStackTest, ForemanCif30kbpsWithoutPacketlossH264) {
+  VideoQualityTest::Params foreman_cif;
+  foreman_cif.call.send_side_bwe = true;
+  foreman_cif.video = {true,  352,          288, 10, 30000, 30000, 30000,

[mflodman, 2016/12/16 11:04:14]

And here too.

[åsapersson, 2016/12/16 11:21:58]

Done.

+                       false, "H264",       1,   0,  0,     false, false,
+                       "",    "foreman_cif"};
+  foreman_cif.analyzer = {"foreman_cif_30kbps_net_delay_0_0_plr_0_H264", 0.0,
+                          0.0, kFullStackTestDurationSecs};
+  RunTest(foreman_cif);
+}
+
 TEST_F(FullStackTest, ForemanCifPlr5H264) {
   VideoQualityTest::Params foreman_cif;
   foreman_cif.call.send_side_bwe = true;
   foreman_cif.video = {true, 352, 288, 30, 30000, 500000, 2000000, false,
                        "H264", 1, 0, 0, false, false, "", "foreman_cif"};
   std::string fec_description;
   foreman_cif.analyzer = {"foreman_cif_delay_50_0_plr_5_H264", 0.0, 0.0,
                           kFullStackTestDurationSecs};
   foreman_cif.pipe.loss_percent = 5;
   foreman_cif.pipe.queue_delay_ms = 50;
@@ skipping 179 matching lines @@
   screenshare.screenshare = {true, 10};
   screenshare.analyzer = {"screenshare_slides_vp9_2sl", 0.0, 0.0,
                           kFullStackTestDurationSecs};
   screenshare.logs = false;
   screenshare.ss = {std::vector<VideoStream>(), 0, 2, 1};
   RunTest(screenshare);
 }
 #endif  // !defined(RTC_DISABLE_VP9)
 
 }  // namespace webrtc