Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Issue 2578543002: Avoid precision loss in MedianSlopeEstimator from int64_t -> double conversion (Closed)

Created:
4 years ago by terelius
Modified:
4 years ago
Reviewers:
brandtr, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 Committed: https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057 Cr-Original-Commit-Position: refs/heads/master@{#15634} Review-Url: https://codereview.webrtc.org/2578543002 Cr-Commit-Position: refs/heads/master@{#15650} Committed: https://chromium.googlesource.com/external/webrtc/+/eb538fdcc6f92deabf5399b1eb24912cec4752a5

Patch Set 1 #

Patch Set 2 : Include only the needed headers. #

Total comments: 4

Patch Set 3 : Nits #

Patch Set 4 : Move test function to anonymous namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -83 lines) Patch
M webrtc/modules/congestion_controller/median_slope_estimator.h View 1 3 chunks +8 lines, -5 lines 0 comments Download
M webrtc/modules/congestion_controller/median_slope_estimator.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc View 1 2 3 1 chunk +28 lines, -69 lines 0 comments Download

Messages

Total messages: 31 (21 generated)
terelius
4 years ago (2016-12-14 14:29:35 UTC) #8
brandtr
lgtm https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc File webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc (right): https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc#newcode31 webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc:31: for (size_t i = 0; i < kPacketCount; ...
4 years ago (2016-12-15 12:25:35 UTC) #9
terelius
https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc File webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc (right): https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc#newcode31 webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc:31: for (size_t i = 0; i < kPacketCount; i++) ...
4 years ago (2016-12-15 13:42:17 UTC) #10
stefan-webrtc
lgtm
4 years ago (2016-12-15 13:44:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2578543002/40001
4 years ago (2016-12-15 14:03:23 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-15 14:31:21 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057 Cr-Commit-Position: refs/heads/master@{#15634}
4 years ago (2016-12-15 14:31:31 UTC) #19
terelius
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.webrtc.org/2572353003/ by terelius@webrtc.org. ...
4 years ago (2016-12-15 14:41:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2578543002/60001
4 years ago (2016-12-16 10:35:35 UTC) #28
commit-bot: I haz the power
4 years ago (2016-12-16 10:37:15 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/eb538fdcc6f92deabf5399b1e...

Powered by Google App Engine
This is Rietveld 408576698