|
|
DescriptionPass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss.
Also clean up the unit test.
BUG=webrtc:6892
Committed: https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057
Cr-Original-Commit-Position: refs/heads/master@{#15634}
Review-Url: https://codereview.webrtc.org/2578543002
Cr-Commit-Position: refs/heads/master@{#15650}
Committed: https://chromium.googlesource.com/external/webrtc/+/eb538fdcc6f92deabf5399b1eb24912cec4752a5
Patch Set 1 #Patch Set 2 : Include only the needed headers. #
Total comments: 4
Patch Set 3 : Nits #Patch Set 4 : Move test function to anonymous namespace #
Messages
Total messages: 31 (21 generated)
The CQ bit was checked by terelius@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeFilter. Also clean up the unit test. BUG=webrtc:6892 ========== to ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator. Also clean up the unit test. BUG=webrtc:6892 ==========
Description was changed from ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator. Also clean up the unit test. BUG=webrtc:6892 ========== to ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 ==========
terelius@webrtc.org changed reviewers: + brandtr@webrtc.org, stefan@webrtc.org
lgtm https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion... File webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc (right): https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion... webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc:31: for (size_t i = 0; i < kPacketCount; i++) { ++i https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion... webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc:37: for (size_t i = 1; i < kPacketCount; i++) { ..
https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion... File webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc (right): https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion... webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc:31: for (size_t i = 0; i < kPacketCount; i++) { On 2016/12/15 12:25:35, brandtr wrote: > ++i Done. https://codereview.webrtc.org/2578543002/diff/20001/webrtc/modules/congestion... webrtc/modules/congestion_controller/median_slope_estimator_unittest.cc:37: for (size_t i = 1; i < kPacketCount; i++) { On 2016/12/15 12:25:35, brandtr wrote: > .. Done.
lgtm
The CQ bit was checked by terelius@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org Link to the patchset: https://codereview.webrtc.org/2578543002/#ps40001 (title: "Nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481810596424040, "parent_rev": "058fb7eca0d8128cdd9913b06ffe5bb36a719447", "commit_rev": "6863ea7ee8f125baf280da04d8c14990c958652d"}
Message was sent while issue was closed.
Description was changed from ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 ========== to ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 Review-Url: https://codereview.webrtc.org/2578543002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 Review-Url: https://codereview.webrtc.org/2578543002 ========== to ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 Committed: https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057 Cr-Commit-Position: refs/heads/master@{#15634} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057 Cr-Commit-Position: refs/heads/master@{#15634}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.webrtc.org/2572353003/ by terelius@webrtc.org. The reason for reverting is: Multiple definitions of TestEstimator.
Message was sent while issue was closed.
Description was changed from ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 Committed: https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057 Cr-Commit-Position: refs/heads/master@{#15634} ========== to ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 Committed: https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057 Cr-Commit-Position: refs/heads/master@{#15634} ==========
The CQ bit was checked by terelius@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by terelius@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from brandtr@webrtc.org, stefan@webrtc.org Link to the patchset: https://codereview.webrtc.org/2578543002/#ps60001 (title: "Move test function to anonymous namespace")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481884532136610, "parent_rev": "beafee3009ac5f17e9e18d9452c3ae8d29ca92b0", "commit_rev": "eb538fdcc6f92deabf5399b1eb24912cec4752a5"}
Message was sent while issue was closed.
Description was changed from ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 Committed: https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057 Cr-Commit-Position: refs/heads/master@{#15634} ========== to ========== Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. Also clean up the unit test. BUG=webrtc:6892 Committed: https://crrev.com/ebcbcc3b2451f5c4fb07f7b37815bd54f364d057 Cr-Original-Commit-Position: refs/heads/master@{#15634} Review-Url: https://codereview.webrtc.org/2578543002 Cr-Commit-Position: refs/heads/master@{#15650} Committed: https://chromium.googlesource.com/external/webrtc/+/eb538fdcc6f92deabf5399b1e... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/external/webrtc/+/eb538fdcc6f92deabf5399b1e... |