Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2577033002: RTCStatsIntegrationTest: TestMemberIsIDReference on all defined IDs. (Closed)

Created:
4 years ago by hbos
Modified:
4 years ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCStatsIntegrationTest: TestMemberIsIDReference on all defined IDs. This makes sure that the referenced stats dictionaries exist. BUG=chromium:627816 Committed: https://crrev.com/7bf536976366443ea59153ff3d22da0ec32badc1 Cr-Commit-Position: refs/heads/master@{#15628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M webrtc/api/rtcstats_integrationtest.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hbos
Please take a look, hta.
4 years ago (2016-12-15 11:17:02 UTC) #4
hta-webrtc
lgtm
4 years ago (2016-12-15 11:29:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2577033002/1
4 years ago (2016-12-15 11:31:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 11:33:40 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-15 11:33:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bf536976366443ea59153ff3d22da0ec32badc1
Cr-Commit-Position: refs/heads/master@{#15628}

Powered by Google App Engine
This is Rietveld 408576698