Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: webrtc/api/rtcstats_integrationtest.cc

Issue 2577033002: RTCStatsIntegrationTest: TestMemberIsIDReference on all defined IDs. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstats_integrationtest.cc
diff --git a/webrtc/api/rtcstats_integrationtest.cc b/webrtc/api/rtcstats_integrationtest.cc
index 0f60377eb221b39c626ea2624bcfa33c3a2e5b93..9600f2a5d093b547c9c766e70e10882378fb7ee8 100644
--- a/webrtc/api/rtcstats_integrationtest.cc
+++ b/webrtc/api/rtcstats_integrationtest.cc
@@ -450,7 +450,7 @@ class RTCStatsReportVerifier {
verifier->TestMemberIsUndefined(stream.media_track_id);
verifier->TestMemberIsIDReference(
stream.transport_id, RTCTransportStats::kType);
- verifier->TestMemberIsDefined(stream.codec_id);
+ verifier->TestMemberIsIDReference(stream.codec_id, RTCCodecStats::kType);
if (stream.media_type.is_defined() && *stream.media_type == "video") {
verifier->TestMemberIsDefined(stream.fir_count);
verifier->TestMemberIsDefined(stream.pli_count);
@@ -510,9 +510,12 @@ class RTCStatsReportVerifier {
verifier.TestMemberIsOptionalIDReference(
transport.rtcp_transport_stats_id, RTCTransportStats::kType);
verifier.TestMemberIsDefined(transport.active_connection);
- verifier.TestMemberIsDefined(transport.selected_candidate_pair_id);
- verifier.TestMemberIsDefined(transport.local_certificate_id);
- verifier.TestMemberIsDefined(transport.remote_certificate_id);
+ verifier.TestMemberIsIDReference(
+ transport.selected_candidate_pair_id, RTCIceCandidatePairStats::kType);
+ verifier.TestMemberIsIDReference(
+ transport.local_certificate_id, RTCCertificateStats::kType);
+ verifier.TestMemberIsIDReference(
+ transport.remote_certificate_id, RTCCertificateStats::kType);
return verifier.ExpectAllMembersSuccessfullyTested();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698