Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2576653003: In RtpPacket do not keep pointer to RtpHeaderExtensionMap (Closed)

Created:
4 years ago by danilchap
Modified:
4 years ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

In RtpPacket do not keep pointer to RtpHeaderExtensionMap Having that dependency require user of RtpPacket to ensure RtpHeaderExtensionMap always outlive packet and that RtpPacket's access to RtpHeaderExtensionMap is properly syncrhonized. Dropping this dependencies make use of RtpPacket less error-prone. BUG=webrtc:5261 Review-Url: https://codereview.webrtc.org/2576653003 Cr-Commit-Position: refs/heads/master@{#15653} Committed: https://chromium.googlesource.com/external/webrtc/+/70f39a30e96082a49809850422c8fe5275accdf8

Patch Set 1 #

Patch Set 2 : Fix bug catched by msan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -58 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 4 chunks +3 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 1 12 chunks +66 lines, -47 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_received.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
danilchap
4 years ago (2016-12-14 16:25:28 UTC) #5
brandtr
lgtm Thanks for changing!
4 years ago (2016-12-16 12:30:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2576653003/20001
4 years ago (2016-12-16 13:22:37 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-16 13:48:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/70f39a30e96082a4980985042...

Powered by Google App Engine
This is Rietveld 408576698