Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_packet_unittest.cc

Issue 2576653003: In RtpPacket do not keep pointer to RtpHeaderExtensionMap (Closed)
Patch Set: Fix bug catched by msan Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_packet_received.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include "webrtc/modules/rtp_rtcp/source/rtp_packet_received.h" 10 #include "webrtc/modules/rtp_rtcp/source/rtp_packet_received.h"
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 EXPECT_EQ(kSeqNum, packet.SequenceNumber()); 286 EXPECT_EQ(kSeqNum, packet.SequenceNumber());
287 EXPECT_EQ(kTimestamp, packet.Timestamp()); 287 EXPECT_EQ(kTimestamp, packet.Timestamp());
288 EXPECT_EQ(kSsrc, packet.Ssrc()); 288 EXPECT_EQ(kSsrc, packet.Ssrc());
289 289
290 RtpPacketToSend::ExtensionManager extensions; 290 RtpPacketToSend::ExtensionManager extensions;
291 extensions.Register(kRtpExtensionTransmissionTimeOffset, 291 extensions.Register(kRtpExtensionTransmissionTimeOffset,
292 kTransmissionOffsetExtensionId); 292 kTransmissionOffsetExtensionId);
293 293
294 int32_t time_offset; 294 int32_t time_offset;
295 EXPECT_FALSE(packet.GetExtension<TransmissionOffset>(&time_offset)); 295 EXPECT_FALSE(packet.GetExtension<TransmissionOffset>(&time_offset));
296 packet.IdentifyExtensions(&extensions); 296 packet.IdentifyExtensions(extensions);
297 EXPECT_TRUE(packet.GetExtension<TransmissionOffset>(&time_offset)); 297 EXPECT_TRUE(packet.GetExtension<TransmissionOffset>(&time_offset));
298 EXPECT_EQ(kTimeOffset, time_offset); 298 EXPECT_EQ(kTimeOffset, time_offset);
299 EXPECT_EQ(0u, packet.payload_size()); 299 EXPECT_EQ(0u, packet.payload_size());
300 EXPECT_EQ(0u, packet.padding_size()); 300 EXPECT_EQ(0u, packet.padding_size());
301 } 301 }
302 302
303 } // namespace webrtc 303 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_packet_received.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698